From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lukas Wunner <lukas@wunner.de>,
LABBE Corentin <clabbe.montjoie@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: modes: add missing [drm] to message printing
Date: Thu, 04 Feb 2016 19:08:39 +0200 [thread overview]
Message-ID: <87vb64tnc8.fsf@intel.com> (raw)
In-Reply-To: <20160204152826.GA13709@wunner.de>
On Thu, 04 Feb 2016, Lukas Wunner <lukas@wunner.de> wrote:
> Hi,
>
> On Thu, Feb 04, 2016 at 03:03:52PM +0100, LABBE Corentin wrote:
>> The warning message in drm_mode_parse_command_line_for_connector miss
>> the [drm] at beginning.
>> This patch add it and take the opportunity to convert
>> printk(KERN_WARNING to pr_warn()
>>
>> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
>> ---
>> drivers/gpu/drm/drm_modes.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
>> index 20775c0..f7448a5 100644
>> --- a/drivers/gpu/drm/drm_modes.c
>> +++ b/drivers/gpu/drm/drm_modes.c
>> @@ -1371,8 +1371,7 @@ bool drm_mode_parse_command_line_for_connector(const char *mode_option,
>> }
>> done:
>> if (i >= 0) {
>> - printk(KERN_WARNING
>> - "parse error at position %i in video mode '%s'\n",
>> + pr_warn("[drm] parse error at position %i in video mode '%s'\n",
>> i, name);
>
> Hm, maybe it's warranted to add a DRM_WARNING macro to include/drm/drmP.h
> and use that instead?
I think it's good as-is for now. We have this all over the place, and
I'd rather see a concerted effort moving away from all this custom stuff
than having a one-off definition for a single patch. And that probably
needs some more discussion, not worth blocking this patch for that.
For pr_warn and friends, one approach is defining pr_fmt() macro at the
top.
BR,
Jani.
>
> Best regards,
>
> Lukas
>
>> mode->specified = false;
>> return false;
>> --
>> 2.4.10
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-02-04 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 14:03 [PATCH] drm: modes: add missing [drm] to message printing LABBE Corentin
2016-02-04 15:28 ` Lukas Wunner
2016-02-04 17:08 ` Jani Nikula [this message]
2016-02-09 9:45 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb64tnc8.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=clabbe.montjoie@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).