From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor) Date: Sun, 28 Dec 2014 08:02:15 -1000 Message-ID: <87vbkvac0o.fsf@eliezer.anholt.net> References: <544F885B.9030206@gmail.com> <1418940218.6596.49.camel@gmail.com> <1419552090.3950.3.camel@gmail.com> <549CB954.9060602@daenzer.net> <1419563434.3950.9.camel@gmail.com> <549CD359.1020608@daenzer.net> <1419594203.1679.1.camel@gmail.com> <86a929ypsa.fsf@hiro.keithp.com> <873881arbn.fsf@eliezer.anholt.net> <86lhlsq040.fsf@hiro.keithp.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1960864021==" Return-path: In-Reply-To: <86lhlsq040.fsf-6d7jPg3SX/+z9DMzp4kqnw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xorg-devel-bounces-go0+a7rfsptAfugRpC6u6w@public.gmane.org Sender: "xorg-devel" To: Keith Packard , Kertesz Laszlo , Michel =?utf-8?Q?D=C3=A4nzer?= Cc: "List, X.Org" , Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org --===============1960864021== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Keith Packard writes: > Eric Anholt writes: > >>> --- a/glamor/glamor_xv.c >>> +++ b/glamor/glamor_xv.c >>> @@ -435,7 +435,7 @@ glamor_xv_put_image(glamor_port_private *port_priv, >>> } >>>=20=20 >>> top =3D (src_y) & ~1; >>> - nlines =3D (src_y + height) - top; >>> + nlines =3D (src_y + src_h) - top; >>>=20=20 >>> switch (id) { >>> case FOURCC_YV12: >> >> If the point is to upload only from the src_[xywh] recctangle, shouldn't >> the glamor_upload_sub_pixmap_to_texture() calls be using src_w instead >> of width, too? > > It doesn't need to, but it could as an optimization. Skipping lines at > the top and bottom is also just an optimization as the source rectangle > defines a subset of the provided buffer, after all. I just fixed that > optimization. FWIW, even as is: Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJUoEWoAAoJELXWKTbR/J7onmoP+wbm/fRQrREWnP0Do2kfe6Lw h+eHHbxR3moVcMKbJof3KboKwulfcDe7zclsNgndSs+2grVVCnPOi5imKcjVVeZW V1iN5khBPmH7tOVsIc0Vk9iMgXlgPHuLF/40BoWtcE+gTlKi2eplbLbyCcEpua52 zFO8cIDt6v3K+UL4+Er5ZtjBvNy2YmEhya68m6BgIr9booeZJ5o1DJecIqDfedis 7XcgcK+f/a8/acZ5l6prb9NkmDx6JSNsbB8944oK8O3pjPE/ftDcpAz99v6YhuO3 gn7P5uzWxo9uVBrRzoXQTUIElP/woesCaEMsGz1fT+26+GEI/eL4PBY3imilKF7e PTFeKLBmXWKL/hMzMEWEXuzFWP3psZFD2MDfuIJ7gPgq6C1igbxDHsBnH/m4zwv4 nVvBEajhMZKbgb36eVoxAr8N8JQ1k31a1h20X6LHRjNXl7kqLzo1r6zTYuGQKWrb Jrx3CVpwxkzM2fOE86hhbxHIOQG9JE00sp9c07JsIwxOytBnlYEeDNlR/yfH2f+k SnkFY6n5JDlYrv+2bcnqG8bXoEzzM42AjtdqOnak4MviKuhiRC8xqJqY4T5JFW2G bAG9i84GvznTI1xbU/ZII8Rl0VlP2rYGGKmKsnG8rOr3OR41W2nre4uM23Q+XfPD M0GQdu2vw1YyInx8fS9V =wtb4 -----END PGP SIGNATURE----- --=-=-=-- --===============1960864021== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KeG9yZy1kZXZl bEBsaXN0cy54Lm9yZzogWC5PcmcgZGV2ZWxvcG1lbnQKQXJjaGl2ZXM6IGh0dHA6Ly9saXN0cy54 Lm9yZy9hcmNoaXZlcy94b3JnLWRldmVsCkluZm86IGh0dHA6Ly9saXN0cy54Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL3hvcmctZGV2ZWw= --===============1960864021==--