From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Subject: Re: [PATCH] drm: Fix return value check in kirin_drm_platform_probe()
Date: Thu, 12 Oct 2017 03:39:59 -0300
Message-ID: <87wp40oon4.fsf@dilma.collabora.co.uk>
References: <1507720636-129038-1-git-send-email-weiyongjun1@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1507720636-129038-1-git-send-email-weiyongjun1@huawei.com> (Wei
        Yongjun's message of "Wed, 11 Oct 2017 11:17:16 +0000")
Sender: linux-kernel-owner@vger.kernel.org
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>, zourongrong@gmail.com, kong.kongxinwei@hisilicon.com, puck.chen@hisilicon.com, airlied@linux.ie, robh@kernel.org, rmk+kernel@armlinux.org.uk, treding@nvidia.com, arnd@arndb.de, daniel.vetter@ffwll.ch, seanpaul@chromium.org, jsarha@ti.com, noralf@tronnes.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
List-Id: dri-devel@lists.freedesktop.org

Wei Yongjun <weiyongjun1@huawei.com> writes:

> In case of error, the function of_graph_get_remote_node() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test..

Looks good.

Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>

-- 
Gabriel Krisman Bertazi