From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] drm/vc4: Advertise supported modifiers for planes Date: Fri, 04 Aug 2017 13:50:07 -0700 Message-ID: <87wp6jqcqo.fsf@eliezer.anholt.net> References: <20170803140359.18379-1-daniels@collabora.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1667757704==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id B43A86E360 for ; Fri, 4 Aug 2017 20:50:09 +0000 (UTC) In-Reply-To: <20170803140359.18379-1-daniels@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Stone Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1667757704== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Daniel Stone writes: > The IN_FORMATS blob allows the kernel to advertise to userspace which > format/modifier combinations are supported, per plane. Use this to > advertise that we support both T_TILED and linear. > > Signed-off-by: Daniel Stone > --- > drivers/gpu/drm/vc4/vc4_plane.c | 22 +++++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_pl= ane.c > index 2968b3ebb895..554325117a4e 100644 > --- a/drivers/gpu/drm/vc4/vc4_plane.c > +++ b/drivers/gpu/drm/vc4/vc4_plane.c > @@ -863,6 +863,20 @@ vc4_update_plane(struct drm_plane *plane, > ctx); > } >=20=20 > +static bool vc4_format_mod_supported(struct drm_plane *plane, > + uint32_t format, > + uint64_t modifier) > +{ > + /* This is easy: both tiled and linear are supported for all formats. */ > + switch (modifier) { > + case DRM_FORMAT_MOD_BROADCOM_VC4_T_TILED: > + case DRM_FORMAT_MOD_LINEAR: > + return true; > + default: > + return false; > + } > +} If this is being used for userspace to decide what modifiers it might want to use for the format, we should disable T_TILED for multi-plane formats. However, it also looks like this won't be called unless dev->mode_config.allow_fb_modifiers, which we should also set. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlmE3f8ACgkQtdYpNtH8 nujqCRAAnIPrAK1yWclIEHusb9Q21yvIf2H28TQqY6fUJk0erKY882gMlrTwUMXN 4QZKnbEqRYKt5aEq35QsAssLh8GqQmvFrkyuU4ludOSnfZPtkGQuLj3HlfDzaWaM D6f8ZLkYdieyT4iSnMQp2P+WxUbDDia+CMZv5Catl+NKuJLXms64WuK81kBzNXsO lJQpEpJBmTVXZzh5+jY0zBRMi81a5Jk9BlSE1A0rFhsovHazeCTzzb40fH0uuVsg WehqY9+L+7GaUFP0A5x+YJZGFpB6Sg+nvffzBTzW3c90GA791Uzfxh+KuhdWGqz5 yaeoeRVcG/RSfDyVxXYbWsWevDkhnRAbT2arDBii4KRHBC4M50hPFNA7qSD3PX+G bag84xj71xT8Q7H0bKPpt4jSIpiE+zd8YLq2Dk7KEYt4V1vEDasgLYEk7oCIwQAD K7lPh6gpM+6quvqMHMYMU5d4MYKAXzcvondp7mIgKHhED90dYLidWch61oTrCJQo ttwuDs0NG+HRkno2cKv7+Lek6SjftE5pXSSypYd/JawCdLwtgoG9Ob8l7OdwTkov cIIHQKFFP5T4jVnDiO58r30D+nUVuCcFkwK4xlvMWWbpWu7Sx9SfWSsZrAGh5BAr nB4WuODKfPePtgV6NKljNB9qSZpcn/5alYAC7xwwfOjh7Rr0W1Y= =Pi2x -----END PGP SIGNATURE----- --=-=-=-- --===============1667757704== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1667757704==--