From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH RFC 1/4] backlight: use static initializers Date: Thu, 11 Sep 2014 11:59:47 +0300 Message-ID: <87wq9acz24.fsf@intel.com> References: <1410364463-12692-1-git-send-email-dh.herrmann@gmail.com> <1410364463-12692-2-git-send-email-dh.herrmann@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 13B356E516 for ; Thu, 11 Sep 2014 01:59:51 -0700 (PDT) In-Reply-To: <1410364463-12692-2-git-send-email-dh.herrmann@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Herrmann , dri-devel@lists.freedesktop.org Cc: Matthew Garrett , Bryan Wu , Lee Jones , linux-kernel@vger.kernel.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org On Wed, 10 Sep 2014, David Herrmann wrote: > Use static initializers instead of setting up global variables during > runtime. This reduces code size and execution time. > > Signed-off-by: David Herrmann Reviewed-by: Jani Nikula > --- > drivers/video/backlight/backlight.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > index bddc8b1..726c6c6 100644 > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/backlight.c > @@ -21,9 +21,9 @@ > #include > #endif > > -static struct list_head backlight_dev_list; > -static struct mutex backlight_dev_list_mutex; > -static struct blocking_notifier_head backlight_notifier; > +static LIST_HEAD(backlight_dev_list); > +static DEFINE_MUTEX(backlight_dev_list_mutex); > +static BLOCKING_NOTIFIER_HEAD(backlight_notifier); > > static const char *const backlight_types[] = { > [BACKLIGHT_RAW] = "raw", > @@ -582,9 +582,6 @@ static int __init backlight_class_init(void) > > backlight_class->dev_groups = bl_device_groups; > backlight_class->pm = &backlight_class_dev_pm_ops; > - INIT_LIST_HEAD(&backlight_dev_list); > - mutex_init(&backlight_dev_list_mutex); > - BLOCKING_INIT_NOTIFIER_HEAD(&backlight_notifier); > > return 0; > } > -- > 2.1.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center