From: Jani Nikula <jani.nikula@linux.intel.com>
To: Guru Das Srinagesh <gurus@codeaurora.org>
Cc: linux-pwm@vger.kernel.org,
"David Collins" <collinsd@codeaurora.org>,
"David Airlie" <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Subbaraman Narayanamurthy" <subbaram@codeaurora.org>
Subject: Re: [PATCH v13 01/11] drm/i915: Use 64-bit division macro
Date: Mon, 27 Apr 2020 16:48:39 +0300 [thread overview]
Message-ID: <87y2qh9gzs.fsf@intel.com> (raw)
In-Reply-To: <20200424221756.GB31118@codeaurora.org>
On Fri, 24 Apr 2020, Guru Das Srinagesh <gurus@codeaurora.org> wrote:
> On Fri, Apr 24, 2020 at 09:17:58AM +0300, Jani Nikula wrote:
>> On Tue, 21 Apr 2020, Guru Das Srinagesh <gurus@codeaurora.org> wrote:
>> > Since the PWM framework is switching struct pwm_state.duty_cycle's
>> > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL
>> > to handle a 64-bit dividend.
>> >
>> > To: Jani Nikula <jani.nikula@linux.intel.com>
>> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> > Cc: David Airlie <airlied@linux.ie>
>> > Cc: Daniel Vetter <daniel@ffwll.ch>
>> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> > Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
>> > Cc: intel-gfx@lists.freedesktop.org
>> > Cc: dri-devel@lists.freedesktop.org
>> >
>>
>> Superfluous blank line.
>
> Will remove.
>
>>
>> Anyway, please preserve the existing acks and reviews [1] so people
>> don't have to do it again.
>>
>> BR,
>> Jani.
>>
>> [1] http://lore.kernel.org/r/87h7yleb0i.fsf@intel.com
>
> I dropped your Acked-by as the patch had to changed to resolve a merge
> conflict when I rebased to tip. Could you please re-review this patch?
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-27 13:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 2:57 [PATCH v13 00/11] Convert PWM period and duty cycle to u64 Guru Das Srinagesh
2020-04-22 2:57 ` [PATCH v13 01/11] drm/i915: Use 64-bit division macro Guru Das Srinagesh
2020-04-24 6:17 ` Jani Nikula
2020-04-24 22:17 ` Guru Das Srinagesh
2020-04-27 13:48 ` Jani Nikula [this message]
2020-04-22 2:57 ` [PATCH v13 09/11] backlight: pwm_bl: Use 64-bit division function Guru Das Srinagesh
2020-05-26 7:00 ` Lee Jones
2020-04-22 8:49 ` [PATCH v13 00/11] Convert PWM period and duty cycle to u64 Daniel Thompson
2020-04-22 23:37 ` Guru Das Srinagesh
2020-04-23 9:20 ` Daniel Thompson
2020-04-23 11:48 ` Lee Jones
2020-04-23 21:53 ` Guru Das Srinagesh
2020-04-24 6:43 ` Lee Jones
2020-04-24 22:14 ` Guru Das Srinagesh
2020-04-27 6:44 ` Lee Jones
2020-04-24 6:45 ` Lee Jones
2020-04-24 6:46 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2qh9gzs.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=collinsd@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurus@codeaurora.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=subbaram@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox