From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
Stefan Schake <stschake@gmail.com>
Subject: Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled
Date: Mon, 13 Nov 2017 16:18:01 -0800 [thread overview]
Message-ID: <87y3n9af2e.fsf@anholt.net> (raw)
In-Reply-To: <1510275907-993-3-git-send-email-stschake@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 524 bytes --]
Stefan Schake <stschake@gmail.com> writes:
> The overflow mem work callback vc4_overflow_mem_work reenables its
> associated interrupt upon completion. To ensure all interrupts are disabled
> when we return from vc4_irq_uninstall, we need to disable it again if
> cancel_work_sync indicated pending work.
Is there a reason we need the interrupts disabled at the V3D level while
we have the IRQ disabled at the irqchip level? Once we re-enable at the
irqchip, we immediately V3D_WRITE(V3D_INTENA, V3D_DRIVER_IRQS) anyway.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-11-14 0:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 1:05 [PATCH 0/2] drm/vc4: Correctly uninstall interrupts Stefan Schake
2017-11-10 1:05 ` [PATCH 1/2] drm/vc4: Account for interrupts in flight Stefan Schake
2017-11-14 0:59 ` Eric Anholt
2017-11-10 1:05 ` [PATCH 2/2] drm/vc4: Ensure interrupts are disabled Stefan Schake
2017-11-14 0:18 ` Eric Anholt [this message]
2017-11-14 11:43 ` Stefan Schake
2017-11-14 19:44 ` Eric Anholt
2017-11-14 23:18 ` Stefan Schake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3n9af2e.fsf@anholt.net \
--to=eric@anholt.net \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=stschake@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox