From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH v3 20/22] drm/vc4: Use drm_gem_fb_create() Date: Wed, 16 Aug 2017 10:27:58 -0700 Message-ID: <87y3qjfmn5.fsf@eliezer.anholt.net> References: <1502631125-13557-1-git-send-email-noralf@tronnes.org> <1502631125-13557-21-git-send-email-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1344026761==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 4B61E6E1C2 for ; Wed, 16 Aug 2017 17:33:10 +0000 (UTC) In-Reply-To: <1502631125-13557-21-git-send-email-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= , dri-devel@lists.freedesktop.org Cc: narmstrong@baylibre.com, daniel.vetter@ffwll.ch, liviu.dudau@arm.com, laurent.pinchart@ideasonboard.com, marex@denx.de, boris.brezillon@free-electrons.com, abrodkin@synopsys.com, z.liuxinliang@hisilicon.com, kong.kongxinwei@hisilicon.com, tomi.valkeinen@ti.com, puck.chen@hisilicon.com, jsarha@ti.com, vincent.abriou@st.com, alison.wang@freescale.com, philippe.cornu@st.com, yannick.fertre@st.com, zourongrong@gmail.com, maxime.ripard@free-electrons.com, shawnguo@kernel.org List-Id: dri-devel@lists.freedesktop.org --===============1344026761== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Noralf Tr=C3=B8nnes writes: > drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now, > so use the function directly. Reviewed-by: Eric Anholt Looks like I should be using the default helper in place of vc4_prepare_fb(), too. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlmUgJ8ACgkQtdYpNtH8 nuhNKBAApNFQu9HOaNPggqCd446z9eo9hbX7qSEzIe2U0Wy/5i6fsL+dHYHVL5bX 2U+ANwG4OZpQghf0deNeufdqgPtdYOQ1pdyeCVPXnbdq89tyaxrvuLrwmHlYtNz7 lvZEzCSCHuqBCJ261Z3+AR3mgDwIDshJnDN9b+zTsKVmBqEhxQnK1+OAzvmrAfzl FHjxcVFzIzwUtGzOwKfD7ZjZd4VfGadPCGrdXZg14vfsgiPc5/im8MQzG8iIK53+ vz3RqG9gdkIWpynrSJJUzJU33LmL9iRDs/nPSmA+DSZgjCTG/eY0cbihn9ytPCcd SgfPBuBmLLr6BVmgY1CqAiZ3stnGgcG8J5DXpUmMeUpE7IgEM2nZMs6kCiv9o1oR 34KW7GKrGB9h7FWnipiel8cB8+sOw8L9qLUmbQOp2xRB9/0qY5blRzlKREBHEV/W zmv+LCMDW7O2QMryA145eoVgXbxNaW7yK/oPrR2/wjr/oIHcIPNIHv+TgvCFlZWg X7gtIWqHNcZYSQYEVrymqo+rVHNra8PLqezsuqqm7zQqh7Y6oYA8/14XAis4Hjnw jfNI/8yjmAIx4njrax1knGMlxpTMHt2evU/jLGQAIk6ER1t3mSAO2feWfrl8UcAG l2D7mS9zUUWpvIw+Rh4P1Ja1uEPchhfQL+Svhj9FhLg9dRVss0o= =i/30 -----END PGP SIGNATURE----- --=-=-=-- --===============1344026761== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1344026761==--