From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH -next] drm/i915: Fix non static symbol warning Date: Mon, 19 Sep 2016 09:33:00 +0300 Message-ID: <87y42o761v.fsf@intel.com> References: <1474074591-16737-1-git-send-email-weiyj.lk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1474074591-16737-1-git-send-email-weiyj.lk@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Wei Yongjun , Daniel Vetter , David Airlie , Mika Kahola Cc: Wei Yongjun , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Sat, 17 Sep 2016, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/gpu/drm/i915/intel_dp.c:1527:5: warning: > symbol 'intel_dp_compute_bpp' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun > --- > drivers/gpu/drm/i915/intel_dp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 69cee9b..acd0c51 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -1524,8 +1524,8 @@ void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock, > } > } > > -int intel_dp_compute_bpp(struct intel_dp *intel_dp, > - struct intel_crtc_state *pipe_config) > +static int intel_dp_compute_bpp(struct intel_dp *intel_dp, > + struct intel_crtc_state *pipe_config) Already fixed upstream. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center