From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: Skype bi-directional video call crashes X server (xserver, mesa, drm, kernel from git, r600g+glamor) Date: Sun, 28 Dec 2014 08:01:07 -1000 Message-ID: <87y4prac2k.fsf@eliezer.anholt.net> References: <544F885B.9030206@gmail.com> <1418940218.6596.49.camel@gmail.com> <1419552090.3950.3.camel@gmail.com> <549CB954.9060602@daenzer.net> <1419563434.3950.9.camel@gmail.com> <549CD359.1020608@daenzer.net> <1419594203.1679.1.camel@gmail.com> <86a929ypsa.fsf@hiro.keithp.com> <873881arbn.fsf@eliezer.anholt.net> <86lhlsq040.fsf@hiro.keithp.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0791750106==" Return-path: In-Reply-To: <86lhlsq040.fsf@hiro.keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Keith Packard , Kertesz Laszlo , Michel =?utf-8?Q?D=C3=A4nzer?= Cc: "List, X.Org" , Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org --===============0791750106== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Keith Packard writes: > Eric Anholt writes: > >>> --- a/glamor/glamor_xv.c >>> +++ b/glamor/glamor_xv.c >>> @@ -435,7 +435,7 @@ glamor_xv_put_image(glamor_port_private *port_priv, >>> } >>>=20=20 >>> top =3D (src_y) & ~1; >>> - nlines =3D (src_y + height) - top; >>> + nlines =3D (src_y + src_h) - top; >>>=20=20 >>> switch (id) { >>> case FOURCC_YV12: >> >> If the point is to upload only from the src_[xywh] recctangle, shouldn't >> the glamor_upload_sub_pixmap_to_texture() calls be using src_w instead >> of width, too? > > It doesn't need to, but it could as an optimization. Skipping lines at > the top and bottom is also just an optimization as the source rectangle > defines a subset of the provided buffer, after all. I just fixed that > optimization. glamor_xv_render is trying to scale from dst coords to src coords using multiplication by src_w / dst_w, though, so if the src pixmap was width wide instead of src_w wide, I think you'd be rendering wrong. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJUoEVjAAoJELXWKTbR/J7o4qIQAJ6AYW3/e8IxHcs89j1nQyx6 U1QcS59bYhwf7/zPqJNe5VYr1MjZS2H4bh0zYxDYfYnF6t8A1Arlwmu3eujxtj/+ Kx7/xJNdmqe0gpcGHuqkoQ7VEP/Shz2lC7bw2BsJyeuxDtldcn6maeZ2exfoAbSq Ksf15/6mvd/ZYITzonXzagy9BBuF+W8+YXJyx5NInmX+o8k+GPHRebUqlMdITC30 atUzEP7WaWTWuckz2la85QaAYIBGXyvE4suP+f4AkbV5Fz6Zb9aW8S977Uj/j4kl A/nk5t//nJZ9s+B4NWP3ru+QLnPSsciaOJKUUD8B5ybeVqsYs4L6pDP8gxJ2pV6O 82xjd0dUBoEeR+zpkoPkLG1Sr5lMSPa4OCxZ1X4hhO76bavPypZOUpJMlzraxX7B +QsD8pEXpSVIJOzrOymRrSsvvgOvMjtubkAweK3Mw4iGpzzTu4g1L+7gflV0vkgc r2DKZVO82KKjES2NMNvNpN/HvMUU+bomnFpvjAtJGuxsQuzWzLvBPIbl4ERvPmNZ Jf5+e6AfwSE+q8kyA+1Klmi34DdupSnoePE7wd3z3QwJ7r4A2k80ktw/7HgwI6zD b7XnTxZUpc+khQuWTcBHxOyi03teyHOaJ9hGG9Va/HnD/DL3/iDQsiZE1Rc9BYNG n8KLZEC569v99gwvwZl4 =UvB7 -----END PGP SIGNATURE----- --=-=-=-- --===============0791750106== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0791750106==--