From: Jani Nikula <jani.nikula@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "Göran Uddeborg" <goeran@uddeborg.se>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: fix module name in edid_firmware log message
Date: Thu, 22 Aug 2019 10:42:33 +0300 [thread overview]
Message-ID: <87zhk1d4t2.fsf@intel.com> (raw)
In-Reply-To: <20190821154955.GM11147@phenom.ffwll.local>
On Wed, 21 Aug 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Aug 21, 2019 at 12:43:12PM +0300, Jani Nikula wrote:
>> The module is drm_kms_helper, not drm_kms_firmware.
>>
>> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204549
>> Reported-by: Göran Uddeborg <goeran@uddeborg.se>
>> Fixes: ac6c35a4d8c7 ("drm: add backwards compatibility support for drm_kms_helper.edid_firmware")
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Thanks, pushed to drm-misc-next.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/drm_kms_helper_common.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_kms_helper_common.c b/drivers/gpu/drm/drm_kms_helper_common.c
>> index d9a5ac81949e..221a8528c993 100644
>> --- a/drivers/gpu/drm/drm_kms_helper_common.c
>> +++ b/drivers/gpu/drm/drm_kms_helper_common.c
>> @@ -40,7 +40,7 @@ MODULE_LICENSE("GPL and additional rights");
>> /* Backward compatibility for drm_kms_helper.edid_firmware */
>> static int edid_firmware_set(const char *val, const struct kernel_param *kp)
>> {
>> - DRM_NOTE("drm_kms_firmware.edid_firmware is deprecated, please use drm.edid_firmware instead.\n");
>> + DRM_NOTE("drm_kms_helper.edid_firmware is deprecated, please use drm.edid_firmware instead.\n");
>>
>> return __drm_set_edid_firmware_path(val);
>> }
>> --
>> 2.20.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-08-22 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 9:43 [PATCH] drm: fix module name in edid_firmware log message Jani Nikula
2019-08-21 15:49 ` Daniel Vetter
2019-08-22 7:42 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhk1d4t2.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=goeran@uddeborg.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox