From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [PATCH v3 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap() Date: Mon, 15 Oct 2018 20:25:41 +1100 Message-ID: <87zhvfzhm2.fsf@concordia.ellerman.id.au> References: <52bd80b06bae0d854d04501e1e136575b77fa9fa.1539092111.git.christophe.leroy@c-s.fr> <87d0sd19vm.fsf@concordia.ellerman.id.au> <87a7nh104q.fsf@concordia.ellerman.id.au> <20181014115810.Horde.99_1JiRv0nxT_Jq3cbpMhw1@messagerie.si.c-s.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20181014115810.Horde.99_1JiRv0nxT_Jq3cbpMhw1@messagerie.si.c-s.fr> Sender: linux-kernel-owner@vger.kernel.org To: LEROY Christophe Cc: dri-devel@lists.freedesktop.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-block@vger.kernel.org, linux-arm-kernel@lists.infradead.org, aneesh.kumar@linux.vnet.ibm.com, Scott Wood , Paul Mackerras , Nicholas Piggin , Li Yang , Kumar Gala , Jens Axboe , Geoff Levand , Dominik Brodowski , Benjamin Herrenschmidt , Bartlomiej Zolnierkiewicz List-Id: dri-devel@lists.freedesktop.org LEROY Christophe writes: > Michael Ellerman a écrit : >> Michael Ellerman writes: >>> Christophe Leroy writes: >>> >>>> Set PAGE_KERNEL directly in the caller and do not rely on a >>>> hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set. >>>> >>>> As already done for PPC64, use pgprot_cache() helpers instead of >>>> _PAGE_XXX flags in PPC32 ioremap() derived functions. >>>> >>>> Signed-off-by: Christophe Leroy >>> >>> Something in here is breaking my p5020ds (both 32-bit and 64-bit): >> >> Oh duh. >> >> That's because I didn't take patch 4. >> >> It didn't have any acks, but I guess I'll just merge it rather than >> breaking things. > > Yes indeed. Maybe should I have followed it more carrefully to ensure > it gets an ack. That's OK, I should have paid more attention to what it was actually doing, I thought it was just a cleanup. cheers