From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 12/14] drm/i915: Clean up encoder->crtc_mask setup Date: Mon, 18 Jun 2018 21:27:52 +0300 Message-ID: <87zhzsx847.fsf@intel.com> References: <20180615164925.28971-1-ville.syrjala@linux.intel.com> <20180615164925.28971-13-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180615164925.28971-13-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAxNSBKdW4gMjAxOCwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+IHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4KPiBVc2UgQklUKHBpcGUpIGZvciBiZXR0ZXIgbGVnaWJpbGl0eSB3 aGVuIHBvcHVsYXRpbmcgdGhlIGNydGNfbWFzawo+IGZvciBlbmNvZGVycy4KPgo+IEFsc28gcmVt b3ZlIHRoZSByZWR1bmRhbnQgcG9zc2libGVfY3J0Y3Mgc2V0dXAgZm9yIHRoZSBUViBlbmNvZGVy Lgo+Cj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwu Y29tPgoKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NydC5jICB8IDQgKyst LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyAgfCAyICstCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMgICB8IDYgKysrLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2R2by5jICB8IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRt aS5jIHwgNiArKystLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHZkcy5jIHwgNiAr KystLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2R2by5jIHwgMiArLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF90di5jICAgfCAzICstLQo+ICA4IGZpbGVzIGNoYW5nZWQs IDE1IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2NydC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf Y3J0LmMKPiBpbmRleCA5NWFhMjljZjJkOWMuLmI2YjE0NjRhNDdiMiAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jcnQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2NydC5jCj4gQEAgLTk2Nyw5ICs5NjcsOSBAQCB2b2lkIGludGVsX2NydF9pbml0 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCWNydC0+YmFzZS50eXBlID0g SU5URUxfT1VUUFVUX0FOQUxPRzsKPiAgCWNydC0+YmFzZS5jbG9uZWFibGUgPSAoMSA8PCBJTlRF TF9PVVRQVVRfRFZPKSB8ICgxIDw8IElOVEVMX09VVFBVVF9IRE1JKTsKPiAgCWlmIChJU19JODMw KGRldl9wcml2KSkKPiAtCQljcnQtPmJhc2UuY3J0Y19tYXNrID0gKDEgPDwgMCk7Cj4gKwkJY3J0 LT5iYXNlLmNydGNfbWFzayA9IEJJVChQSVBFX0EpOwo+ICAJZWxzZQo+IC0JCWNydC0+YmFzZS5j cnRjX21hc2sgPSAoMSA8PCAwKSB8ICgxIDw8IDEpIHwgKDEgPDwgMik7Cj4gKwkJY3J0LT5iYXNl LmNydGNfbWFzayA9IEJJVChQSVBFX0EpIHwgQklUKFBJUEVfQikgfCBCSVQoUElQRV9DKTsKPiAg Cj4gIAlpZiAoSVNfR0VOMihkZXZfcHJpdikpCj4gIAkJY29ubmVjdG9yLT5pbnRlcmxhY2VfYWxs b3dlZCA9IDA7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBpbmRleCBjYTczMzg3YmQ1OTYu LjA0NjJkOWIzMWY3ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k ZGkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gQEAgLTM1MTQs NyArMzUxNCw3IEBAIHZvaWQgaW50ZWxfZGRpX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LCBlbnVtIHBvcnQgcG9ydCkKPiAgCWludGVsX2VuY29kZXItPnR5cGUgPSBJTlRF TF9PVVRQVVRfRERJOwo+ICAJaW50ZWxfZW5jb2Rlci0+cG93ZXJfZG9tYWluID0gaW50ZWxfcG9y dF90b19wb3dlcl9kb21haW4ocG9ydCk7Cj4gIAlpbnRlbF9lbmNvZGVyLT5wb3J0ID0gcG9ydDsK PiAtCWludGVsX2VuY29kZXItPmNydGNfbWFzayA9ICgxIDw8IDApIHwgKDEgPDwgMSkgfCAoMSA8 PCAyKTsKPiArCWludGVsX2VuY29kZXItPmNydGNfbWFzayA9IEJJVChQSVBFX0EpIHwgQklUKFBJ UEVfQikgfCBCSVQoUElQRV9DKTsKPiAgCWludGVsX2VuY29kZXItPmNsb25lYWJsZSA9IDA7Cj4g IAo+ICAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEpCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cC5jCj4gaW5kZXggYTU4YmFjMDFhZWVhLi5kOTgzOTI0ZWQ2OWEgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RwLmMKPiBAQCAtNjQ3NCwxMSArNjQ3NCwxMSBAQCBib29sIGludGVsX2RwX2luaXQo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJaW50ZWxfZW5jb2Rlci0+cG93 ZXJfZG9tYWluID0gaW50ZWxfcG9ydF90b19wb3dlcl9kb21haW4ocG9ydCk7Cj4gIAlpZiAoSVNf Q0hFUlJZVklFVyhkZXZfcHJpdikpIHsKPiAgCQlpZiAocG9ydCA9PSBQT1JUX0QpCj4gLQkJCWlu dGVsX2VuY29kZXItPmNydGNfbWFzayA9IDEgPDwgMjsKPiArCQkJaW50ZWxfZW5jb2Rlci0+Y3J0 Y19tYXNrID0gQklUKFBJUEVfQyk7Cj4gIAkJZWxzZQo+IC0JCQlpbnRlbF9lbmNvZGVyLT5jcnRj X21hc2sgPSAoMSA8PCAwKSB8ICgxIDw8IDEpOwo+ICsJCQlpbnRlbF9lbmNvZGVyLT5jcnRjX21h c2sgPSBCSVQoUElQRV9BKSB8IEJJVChQSVBFX0IpOwo+ICAJfSBlbHNlIHsKPiAtCQlpbnRlbF9l bmNvZGVyLT5jcnRjX21hc2sgPSAoMSA8PCAwKSB8ICgxIDw8IDEpIHwgKDEgPDwgMik7Cj4gKwkJ aW50ZWxfZW5jb2Rlci0+Y3J0Y19tYXNrID0gQklUKFBJUEVfQSkgfCBCSVQoUElQRV9CKSB8IEJJ VChQSVBFX0MpOwo+ICAJfQo+ICAJaW50ZWxfZW5jb2Rlci0+Y2xvbmVhYmxlID0gMDsKPiAgCWlu dGVsX2VuY29kZXItPnBvcnQgPSBwb3J0Owo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kdm8uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2R2by5jCj4gaW5k ZXggMjdmMTZkYjg5NTNhLi4yN2MxODY4MGRlYjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHZvLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k dm8uYwo+IEBAIC00OTksNyArNDk5LDcgQEAgdm9pZCBpbnRlbF9kdm9faW5pdChzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAkJaW50ZWxfZW5jb2Rlci0+dHlwZSA9IElOVEVM X09VVFBVVF9EVk87Cj4gIAkJaW50ZWxfZW5jb2Rlci0+cG93ZXJfZG9tYWluID0gUE9XRVJfRE9N QUlOX1BPUlRfT1RIRVI7Cj4gIAkJaW50ZWxfZW5jb2Rlci0+cG9ydCA9IHBvcnQ7Cj4gLQkJaW50 ZWxfZW5jb2Rlci0+Y3J0Y19tYXNrID0gKDEgPDwgMCkgfCAoMSA8PCAxKTsKPiArCQlpbnRlbF9l bmNvZGVyLT5jcnRjX21hc2sgPSBCSVQoUElQRV9BKSB8IEJJVChQSVBFX0IpOwo+ICAKPiAgCQlz d2l0Y2ggKGR2by0+dHlwZSkgewo+ICAJCWNhc2UgSU5URUxfRFZPX0NISVBfVE1EUzoKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfaGRtaS5jCj4gaW5kZXggMDlkN2QzOGYwZDRlLi42NjZiY2MxYTQ2NjAg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jCj4gQEAgLTI0MDUsMTEgKzI0MDUsMTEg QEAgdm9pZCBpbnRlbF9oZG1pX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LAo+ICAJaW50ZWxfZW5jb2Rlci0+cG9ydCA9IHBvcnQ7Cj4gIAlpZiAoSVNfQ0hFUlJZVklFVyhk ZXZfcHJpdikpIHsKPiAgCQlpZiAocG9ydCA9PSBQT1JUX0QpCj4gLQkJCWludGVsX2VuY29kZXIt PmNydGNfbWFzayA9IDEgPDwgMjsKPiArCQkJaW50ZWxfZW5jb2Rlci0+Y3J0Y19tYXNrID0gQklU KFBJUEVfQyk7Cj4gIAkJZWxzZQo+IC0JCQlpbnRlbF9lbmNvZGVyLT5jcnRjX21hc2sgPSAoMSA8 PCAwKSB8ICgxIDw8IDEpOwo+ICsJCQlpbnRlbF9lbmNvZGVyLT5jcnRjX21hc2sgPSBCSVQoUElQ RV9BKSB8IEJJVChQSVBFX0IpOwo+ICAJfSBlbHNlIHsKPiAtCQlpbnRlbF9lbmNvZGVyLT5jcnRj X21hc2sgPSAoMSA8PCAwKSB8ICgxIDw8IDEpIHwgKDEgPDwgMik7Cj4gKwkJaW50ZWxfZW5jb2Rl ci0+Y3J0Y19tYXNrID0gQklUKFBJUEVfQSkgfCBCSVQoUElQRV9CKSB8IEJJVChQSVBFX0MpOwo+ ICAJfQo+ICAJaW50ZWxfZW5jb2Rlci0+Y2xvbmVhYmxlID0gMSA8PCBJTlRFTF9PVVRQVVRfQU5B TE9HOwo+ICAJLyoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHZk cy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHZkcy5jCj4gaW5kZXggYmIwNjc0NGQy OGE0Li43NTNkZjhkZDlhMDMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfbHZkcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHZkcy5jCj4gQEAg LTEwODUsMTEgKzEwODUsMTEgQEAgdm9pZCBpbnRlbF9sdmRzX2luaXQoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJaW50ZWxfZW5jb2Rlci0+cG9ydCA9IFBPUlRfTk9ORTsK PiAgCWludGVsX2VuY29kZXItPmNsb25lYWJsZSA9IDA7Cj4gIAlpZiAoSEFTX1BDSF9TUExJVChk ZXZfcHJpdikpCj4gLQkJaW50ZWxfZW5jb2Rlci0+Y3J0Y19tYXNrID0gKDEgPDwgMCkgfCAoMSA8 PCAxKSB8ICgxIDw8IDIpOwo+ICsJCWludGVsX2VuY29kZXItPmNydGNfbWFzayA9IEJJVChQSVBF X0EpIHwgQklUKFBJUEVfQikgfCBCSVQoUElQRV9DKTsKPiAgCWVsc2UgaWYgKElTX0dFTjQoZGV2 X3ByaXYpKQo+IC0JCWludGVsX2VuY29kZXItPmNydGNfbWFzayA9ICgxIDw8IDApIHwgKDEgPDwg MSk7Cj4gKwkJaW50ZWxfZW5jb2Rlci0+Y3J0Y19tYXNrID0gQklUKFBJUEVfQSkgfCBCSVQoUElQ RV9CKTsKPiAgCWVsc2UKPiAtCQlpbnRlbF9lbmNvZGVyLT5jcnRjX21hc2sgPSAoMSA8PCAxKTsK PiArCQlpbnRlbF9lbmNvZGVyLT5jcnRjX21hc2sgPSBCSVQoUElQRV9CKTsKPiAgCj4gIAlkcm1f Y29ubmVjdG9yX2hlbHBlcl9hZGQoY29ubmVjdG9yLCAmaW50ZWxfbHZkc19jb25uZWN0b3JfaGVs cGVyX2Z1bmNzKTsKPiAgCWNvbm5lY3Rvci0+ZGlzcGxheV9pbmZvLnN1YnBpeGVsX29yZGVyID0g U3ViUGl4ZWxIb3Jpem9udGFsUkdCOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9zZHZvLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMKPiBpbmRl eCBlNmE2NGIzZWNkOTEuLmVmNTQwY2YwMDM3MyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9zZHZvLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9z ZHZvLmMKPiBAQCAtMjc0MSw3ICsyNzQxLDcgQEAgaW50ZWxfc2R2b19vdXRwdXRfc2V0dXAoc3Ry dWN0IGludGVsX3Nkdm8gKmludGVsX3Nkdm8sIHVpbnQxNl90IGZsYWdzKQo+ICAJCQkgICAgICBi eXRlc1swXSwgYnl0ZXNbMV0pOwo+ICAJCXJldHVybiBmYWxzZTsKPiAgCX0KPiAtCWludGVsX3Nk dm8tPmJhc2UuY3J0Y19tYXNrID0gKDEgPDwgMCkgfCAoMSA8PCAxKSB8ICgxIDw8IDIpOwo+ICsJ aW50ZWxfc2R2by0+YmFzZS5jcnRjX21hc2sgPSBCSVQoUElQRV9BKSB8IEJJVChQSVBFX0IpIHwg QklUKFBJUEVfQyk7Cj4gIAo+ICAJcmV0dXJuIHRydWU7Cj4gIH0KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdHYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3R2LmMKPiBpbmRleCAyNGRjMzY4ZmRhYTEuLjdhNjhjMTMyZDA4YyAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF90di5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfdHYuYwo+IEBAIC0xNTIwLDkgKzE1MjAsOCBAQCBpbnRlbF90dl9pbml0KHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCWludGVsX2VuY29kZXItPnR5cGUgPSBJ TlRFTF9PVVRQVVRfVFZPVVQ7Cj4gIAlpbnRlbF9lbmNvZGVyLT5wb3dlcl9kb21haW4gPSBQT1dF Ul9ET01BSU5fUE9SVF9PVEhFUjsKPiAgCWludGVsX2VuY29kZXItPnBvcnQgPSBQT1JUX05PTkU7 Cj4gLQlpbnRlbF9lbmNvZGVyLT5jcnRjX21hc2sgPSAoMSA8PCAwKSB8ICgxIDw8IDEpOwo+ICsJ aW50ZWxfZW5jb2Rlci0+Y3J0Y19tYXNrID0gQklUKFBJUEVfQSkgfCBCSVQoUElQRV9CKTsKPiAg CWludGVsX2VuY29kZXItPmNsb25lYWJsZSA9IDA7Cj4gLQlpbnRlbF9lbmNvZGVyLT5iYXNlLnBv c3NpYmxlX2NydGNzID0gKCgxIDw8IDApIHwgKDEgPDwgMSkpOwo+ICAJaW50ZWxfdHYtPnR5cGUg PSBEUk1fTU9ERV9DT05ORUNUT1JfVW5rbm93bjsKPiAgCj4gIAkvKiBCSU9TIG1hcmdpbiB2YWx1 ZXMgKi8KCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVy Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=