From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 2/5] drm/edid: Introduce drm_default_rgb_quant_range() Date: Sat, 21 Jan 2017 06:50:57 +1100 Message-ID: <87ziilbjdq.fsf@eliezer.anholt.net> References: <20170111125725.8086-1-ville.syrjala@linux.intel.com> <20170111125725.8086-3-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0969186421==" Return-path: In-Reply-To: <20170111125725.8086-3-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0969186421== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ville.syrjala@linux.intel.com writes: > From: Ville Syrj=C3=A4l=C3=A4 > > Make the code selecting the RGB quantization range a little less magicy > by wrapping it up in a small helper. This series seems good. I won't have the ability to test it on vc4 within a reasonable time frame, so you can add an Acked-by from me if you'd like. Just one comment that you can take or leave: > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 > --- > drivers/gpu/drm/drm_edid.c | 18 ++++++++++++++++++ > drivers/gpu/drm/i915/intel_dp.c | 4 +++- > drivers/gpu/drm/i915/intel_hdmi.c | 3 ++- > drivers/gpu/drm/vc4/vc4_hdmi.c | 4 +++- > include/drm/drm_edid.h | 2 ++ > 5 files changed, 28 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 4ff04aa84dd0..304c583b8000 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3768,6 +3768,24 @@ bool drm_rgb_quant_range_selectable(struct edid *e= did) > } > EXPORT_SYMBOL(drm_rgb_quant_range_selectable); >=20=20 > +/** > + * drm_default_rgb_quant_range - default RGB quantization range > + * @mode: display mode > + * > + * Determine the default RGB quantization range for the mode, > + * as specified in CEA-861. > + * > + * Return: The default RGB quantization range for the mode > + */ > +enum hdmi_quantization_range > +drm_default_rgb_quant_range(const struct drm_display_mode *mode) > +{ > + return drm_match_cea_mode(mode) > 1 ? > + HDMI_QUANTIZATION_RANGE_LIMITED : > + HDMI_QUANTIZATION_RANGE_FULL; It might be nice to add a comment here like /* All CEA modes other than VIC 1 use limited quantization range. */ When I first had to put this logic in vc4, I was surprised by it and figured that it was an off-by-one bug in code that was trying to say "if it's any CEA mode then it should be limited range" > +} > +EXPORT_SYMBOL(drm_default_rgb_quant_range); --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAliCaiEACgkQtdYpNtH8 nuhDJhAAg8XtXp0xo9vB2ilP2JjeCM4sqipLcGLq4fMLRgxgFM6MXpMSgNrPZ+in WBioqvt7M3/7/epC4qlhluVJvxkZX7jlUAfbIR0NAikHJJe+sTI/8LeZ/5H1gaSR S8y8Pnoqdd4tdfbn4uQlVqpoHPJlCOMRRRcSkJlEy10xpnCf8KXTu02S7fTkp1f/ 1vzZBN6Mt309kjICO7eO/tVwoNA+ttak4v+9Xzgbf3/sXSemt+v//c3p4V/9qH3J mU0SceI4S0KA7j3OYOfx/5givvfO8pa5Oi1nUhHA+UdkRMupXauj8Rv+fGxhBwYY +po0AXbL7fNsCz69HkkqGb4WOCXYLsacMw4byI+WvUDv+hOm+F0qwu9UoHn/PC+7 rA/npUF3soCUziiik3zdc5P8yFAWI8y8Ux6xFMqgoe+oqij4EhE+Pfaee3jua0Xe /uIc/Ed5fmejue++pKk0FAAKdq5KOSC1DzJvYO/Dp6rJnjIpe85lZUWAXm8Xzten PxsX4WhP8oUZywBav8GleOlLPm2Hlcf2FodWYc3O+ctmQ9aScqys85ZawGTTksC+ TNP/KgcwNaUI2K2nXOQw1hbrPlUrfkJEJe14oD7bQkt3ft8z/TVJWjfSGEKacr7o ao91p6t8h9xCV9hudq4TtO6ZexMYWsO4KPmE2P0jTmuH/Snea0Y= =mwH2 -----END PGP SIGNATURE----- --=-=-=-- --===============0969186421== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0969186421==--