From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01ED3CCD183 for ; Thu, 9 Oct 2025 15:37:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 37DAD10EA97; Thu, 9 Oct 2025 15:37:29 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D74C10EA97 for ; Thu, 9 Oct 2025 15:37:28 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07F181688; Thu, 9 Oct 2025 08:37:20 -0700 (PDT) Received: from [10.1.34.29] (e122027.cambridge.arm.com [10.1.34.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 52DC83F59E; Thu, 9 Oct 2025 08:37:25 -0700 (PDT) Message-ID: <88e18ee6-ee17-4a6e-8ba7-e33bd18766f0@arm.com> Date: Thu, 9 Oct 2025 16:37:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 10/12] drm/panfrost: Remove unused device property To: =?UTF-8?Q?Adri=C3=A1n_Larumbe?= , linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Boris Brezillon , kernel@collabora.com, Rob Herring , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter References: <20251007150216.254250-1-adrian.larumbe@collabora.com> <20251007150216.254250-11-adrian.larumbe@collabora.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20251007150216.254250-11-adrian.larumbe@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 07/10/2025 16:01, Adrián Larumbe wrote: > The as_in_use_mask device state variable is no longer in use. > > Reviewed-by: Boris Brezillon > Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_device.h | 1 - > drivers/gpu/drm/panfrost/panfrost_mmu.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/panfrost/panfrost_device.h > index 45d77cda8b89..e61c4329fd07 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_device.h > +++ b/drivers/gpu/drm/panfrost/panfrost_device.h > @@ -147,7 +147,6 @@ struct panfrost_device { > DECLARE_BITMAP(is_suspended, PANFROST_COMP_BIT_MAX); > > spinlock_t as_lock; > - unsigned long as_in_use_mask; > unsigned long as_alloc_mask; > unsigned long as_faulty_mask; > struct list_head as_lru_list; > diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c > index 7bf386d25453..69699b3c756a 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c > +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c > @@ -719,7 +719,6 @@ static void panfrost_mmu_release_ctx(struct kref *kref) > pm_runtime_put_autosuspend(pfdev->base.dev); > > clear_bit(mmu->as, &pfdev->as_alloc_mask); > - clear_bit(mmu->as, &pfdev->as_in_use_mask); > list_del(&mmu->list); > } > spin_unlock(&pfdev->as_lock);