Re: [PATCH v3 0/9] drm/i915: Add support for Intel's eDP backlight controls

[Lyude Paul <lyude@redhat.com>]

Poke, can we please get some reviews on this? It's been over a week.

On Fri, 2020-12-04 at 17:35 -0500, Lyude Paul wrote:
> A while ago we ran into issues while trying to enable the eDP backlight
> control interface as defined by VESA, in order to make the DPCD
> backlight controls on newer laptop panels work. The issue ended up being
> much more complicated however, as we also apparently needed to add
> support for an Intel-specific DPCD backlight control interface as the
> VESA interface is broken on many laptop panels. For lack of a better
> name, we just call this the Intel HDR backlight interface.
> 
> While this only adds support for the SDR backlight mode (I think), this
> will fix a lot of user's laptop panels that we weren't able to properly
> automatically detect DPCD backlight controls on previously.
> 
> Series-wide changes in v3:
> * Pass down brightness values to enable/disable backlight callbacks in a
>   separate patch
> * Rebase
> 
> Lyude Paul (9):
>   drm/i915/dp: Program source OUI on eDP panels
>   drm/i915: Rename pwm_* backlight callbacks to ext_pwm_*
>   drm/i915: Pass down brightness values to enable/disable backlight
>     callbacks
>   drm/i915: Keep track of pwm-related backlight hooks separately
>   drm/i915/dp: Rename eDP VESA backlight interface functions
>   drm/i915/dp: Add register definitions for Intel HDR backlight
>     interface
>   drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)
>   drm/i915/dp: Allow forcing specific interfaces through
>     enable_dpcd_backlight
>   drm/dp: Revert "drm/dp: Introduce EDID-based quirks"
> 
>  drivers/gpu/drm/drm_dp_helper.c               |  83 +---
>  drivers/gpu/drm/drm_dp_mst_topology.c         |   3 +-
>  .../drm/i915/display/intel_display_types.h    |  18 +-
>  drivers/gpu/drm/i915/display/intel_dp.c       |  42 +-
>  .../drm/i915/display/intel_dp_aux_backlight.c | 394 +++++++++++++---
>  drivers/gpu/drm/i915/display/intel_dp_mst.c   |   3 +-
>  .../i915/display/intel_dsi_dcs_backlight.c    |   7 +-
>  drivers/gpu/drm/i915/display/intel_panel.c    | 435 ++++++++++--------
>  drivers/gpu/drm/i915/display/intel_panel.h    |   4 +
>  drivers/gpu/drm/i915/display/intel_psr.c      |   2 +-
>  drivers/gpu/drm/i915/i915_params.c            |   2 +-
>  include/drm/drm_dp_helper.h                   |  21 +-
>  12 files changed, 655 insertions(+), 359 deletions(-)
> 

-- 
Sincerely,
   Lyude Paul (she/her)
   Software Engineer at Red Hat
   
Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've
asked me a question, are waiting for a review/merge on a patch, etc. and I
haven't responded in a while, please feel free to send me another email to check
on my status. I don't bite!

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel