From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: mark display port DPMS state as ON when enabling output Date: Sun, 03 Oct 2010 22:05:13 +0100 Message-ID: <89k77n$p47jkc@fmsmga001.fm.intel.com> References: <1286138029-3728-1-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1286138029-3728-1-git-send-email-keithp@keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard , intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Sun, 3 Oct 2010 13:33:49 -0700, Keith Packard wrote: > The display port DPMS state is tracked internally in the display port > driver so that when a hotplug event comes along, the driver can know > whether to try retraining the link. This doesn't work well if the > driver never sets the DPMS state to ON when the output is enabled. It appears that all users (crtc and encoders) are tracking dpms_mode, in one form or another. Should we move this to core? Is there any hardware that requires notification even when there is no change? -Chris -- Chris Wilson, Intel Open Source Technology Centre