From: Chris Wilson <chris@chris-wilson.co.uk>
To: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm: Cleanup after failing to create master->unique and dev->name
Date: Sat, 24 Jul 2010 18:56:39 +0100 [thread overview]
Message-ID: <89kc63$hi26p3@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1279992577-31841-1-git-send-email-chris@chris-wilson.co.uk>
On Sat, 24 Jul 2010 18:29:35 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> @@ -323,7 +358,9 @@ int drm_setversion(struct drm_device *dev, void *data, struct drm_file *file_pri
> /*
> * Version 1.1 includes tying of DRM to specific device
> */
> - drm_set_busid(dev, file_priv);
> + retcode = drm_set_busid(dev, file_priv);
> + if (retcode)
> + goto done;
And actually returning the error code is breaking xorg 1.8.99...
Hmm.
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-07-24 17:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-24 17:29 [PATCH 1/3] drm: Cleanup after failing to create master->unique and dev->name Chris Wilson
2010-07-24 17:29 ` [PATCH 2/3] drm: Free devname along with master->unique Chris Wilson
2010-07-24 17:29 ` [PATCH 3/3] agp/intel: Destroy the scatterlist on allocation failure Chris Wilson
2010-07-27 2:00 ` Zhenyu Wang
2010-07-27 7:42 ` Chris Wilson
2010-08-02 2:26 ` Eric Anholt
2010-07-24 17:56 ` Chris Wilson [this message]
2010-07-24 18:34 ` [PATCH] drm: Cleanup after failing to create master->unique and dev->name Chris Wilson
2010-08-02 0:13 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='89kc63$hi26p3@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox