From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53FEEC4338F for ; Thu, 5 Aug 2021 16:17:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 143F960F58 for ; Thu, 5 Aug 2021 16:17:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 143F960F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 227526EAD4; Thu, 5 Aug 2021 16:17:50 +0000 (UTC) Received: from aposti.net (aposti.net [89.234.176.197]) by gabe.freedesktop.org (Postfix) with ESMTPS id A1C676EAD4 for ; Thu, 5 Aug 2021 16:17:48 +0000 (UTC) Date: Thu, 05 Aug 2021 18:17:32 +0200 From: Paul Cercueil Subject: Re: [PATCH v2 8/8] [RFC] drm/ingenic: convert to component framework for jz4780 hdmi To: "H. Nikolaus Schaller" Cc: Laurent Pinchart , Rob Herring , Mark Rutland , Thomas Bogendoerfer , Geert Uytterhoeven , Kees Cook , "Eric W. Biederman" , Miquel Raynal , David Airlie , Daniel Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Jernej Skrabec , Ezequiel Garcia , Harry Wentland , Sam Ravnborg , Maxime Ripard , Hans Verkuil , devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, Paul Boddie , Jonas Karlman , dri-devel@lists.freedesktop.org Message-Id: <8XJDXQ.X70C5WOD0QB7@crapouillou.net> In-Reply-To: References: <77554dd2612f418f6ab74a8be06c82b71410e0e6.1628172477.git.hns@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Nikolaus and Laurent, Le jeu., ao=FBt 5 2021 at 18:07:20 +0200, H. Nikolaus Schaller=20 a =E9crit : > Hi Laurent, >=20 >> Am 05.08.2021 um 17:04 schrieb Laurent Pinchart=20 >> : >>=20 >> Hi Nikolaus, >>=20 >> Thank you for the patch. >>=20 >> On Thu, Aug 05, 2021 at 04:07:57PM +0200, H. Nikolaus Schaller=20 >> wrote: >>> This patch attempts to convert the ingenic-dw-hdmi driver >>> into a version that uses the component framework. >>=20 >> Why ? What problem would this solve ? >=20 > Well, it was suggested in a v1 we did post several months ago. I have=20 > not > looked up by whom and do not exactly remember the reasons. >=20 > We now simply thought that it is common style since dome dw-hdmi=20 > drivers > make use of it but some others don't. And we got it working without. >=20 > If it is not needed/requested by anyone, we can drop it from v3 (or=20 > add later). I don't remember exactly TBH - the only reason to use a component is to=20 have access to the main driver's "drm_device" structure. The IPU needs=20 it for instance, to register planes; but I don't think this HDMI driver=20 needs it as it registers a bridge. Cheers, -Paul