From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D39DC433F5 for ; Tue, 5 Oct 2021 20:44:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31C7861181 for ; Tue, 5 Oct 2021 20:44:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 31C7861181 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2EBF66E45C; Tue, 5 Oct 2021 20:44:13 +0000 (UTC) Received: from aposti.net (aposti.net [89.234.176.197]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5243F6E45C for ; Tue, 5 Oct 2021 20:44:12 +0000 (UTC) Date: Tue, 05 Oct 2021 21:43:56 +0100 From: Paul Cercueil Subject: Re: [PATCH v5 3/7] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema To: "H. Nikolaus Schaller" Cc: Rob Herring , Mark Rutland , Thomas Bogendoerfer , Geert Uytterhoeven , Kees Cook , "Eric W. Biederman" , Miquel Raynal , David Airlie , Daniel Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jernej Skrabec , Ezequiel Garcia , Harry Wentland , Sam Ravnborg , Maxime Ripard , Hans Verkuil , Liam Girdwood , Mark Brown , Paul Boddie , devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, Jonas Karlman , dri-devel@lists.freedesktop.org, Rob Herring Message-Id: <8XUI0R.KDQ64KIMI9BU@crapouillou.net> In-Reply-To: <518d5db83e84e3f0326854c5afb53a92e7ae4e41.1633436959.git.hns@goldelico.com> References: <518d5db83e84e3f0326854c5afb53a92e7ae4e41.1633436959.git.hns@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Nikolaus, Le mar., oct. 5 2021 at 14:29:15 +0200, H. Nikolaus Schaller=20 a =E9crit : > From: Sam Ravnborg >=20 > Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. > Based on .txt binding from Zubair Lutfullah Kakakhel >=20 > Signed-off-by: Sam Ravnborg > Signed-off-by: H. Nikolaus Schaller > Cc: Rob Herring > Cc: devicetree@vger.kernel.org > --- > .../bindings/display/ingenic-jz4780-hdmi.yaml | 79=20 > +++++++++++++++++++ > 1 file changed, 79 insertions(+) > create mode 100644=20 > Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml >=20 > diff --git=20 > a/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml=20 > b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml > new file mode 100644 > index 000000000000..5bcb342da86f > --- /dev/null > +++=20 > b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml > @@ -0,0 +1,79 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/ingenic-jz4780-hdmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bindings for Ingenic JZ4780 HDMI Transmitter > + > +maintainers: > + - H. Nikolaus Schaller > + > +description: | > + The HDMI Transmitter in the Ingenic JZ4780 is a Synopsys=20 > DesignWare HDMI 1.4 > + TX controller IP with accompanying PHY IP. My dmesg disagrees: dw-hdmi-ingenic 10180000.hdmi: Detected HDMI TX controller v1.31a with=20 HDCP (DWC HDMI 3D TX PHY) Or am I comparing apples to oranges? > + > +allOf: > + - $ref: bridge/synopsys,dw-hdmi.yaml# > + > +properties: > + compatible: > + const: ingenic,jz4780-dw-hdmi > + > + reg-io-width: > + const: 4 > + > + clocks: > + maxItems: 2 > + > + hdmi-5v-supply: > + description: Optional regulator to provide +5V at the connector > + > + ddc-i2c-bus: > + description: An I2C interface if the internal DDC I2C driver is=20 > not to be used This property is used within=20 (drivers/gpu/drm/bridge/synopsys/dw-hdmi.c); I think it would make=20 sense to move it to bridge/synopsys,dw-hdmi.yaml. Cheers, -Paul > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > +required: > + - compatible > + - clocks > + - clock-names > + - ports > + - reg-io-width > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + hdmi: hdmi@10180000 { > + compatible =3D "ingenic,jz4780-dw-hdmi"; > + reg =3D <0x10180000 0x8000>; > + reg-io-width =3D <4>; > + ddc-i2c-bus =3D <&i2c4>; > + interrupt-parent =3D <&intc>; > + interrupts =3D <3>; > + clocks =3D <&cgu JZ4780_CLK_AHB0>, <&cgu JZ4780_CLK_HDMI>; > + clock-names =3D "iahb", "isfr"; > + > + ports { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + hdmi_in: port@0 { > + reg =3D <0>; > + dw_hdmi_in: endpoint { > + remote-endpoint =3D <&jz4780_lcd_out>; > + }; > + }; > + hdmi_out: port@1 { > + reg =3D <1>; > + dw_hdmi_out: endpoint { > + remote-endpoint =3D <&hdmi_con>; > + }; > + }; > + }; > + }; > + > +... > -- > 2.33.0 >=20