From: "Christian König" <christian.koenig@amd.com>
To: "Michel Dänzer" <michel@daenzer.net>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [2/2] drm/ttm: make TT creation purely optional v3
Date: Thu, 6 Aug 2020 10:43:00 +0200 [thread overview]
Message-ID: <8d5809be-104d-40e8-e8bb-5186d5b565b5@amd.com> (raw)
In-Reply-To: <b818b065-50cd-9e8a-3cff-01dd124a04c4@daenzer.net>
Am 06.08.20 um 10:01 schrieb Michel Dänzer:
> On 2020-08-06 9:13 a.m., Christian König wrote:
>> Am 05.08.20 um 18:16 schrieb Michel Dänzer:
>>> On 2020-06-29 5:19 p.m., Christian König wrote:
>>>> We only need the page array when the BO is about to be accessed.
>>>>
>>>> So not only populate, but also create it on demand.
>>>>
>>>> v2: move NULL check into ttm_tt_create()
>>>> v3: fix the occurrence in ttm_bo_kmap_ttm as well
>>> This broke amdgpu userptr functionality for me, in particular all
>>> GL_AMD_pinned_memory piglit tests, e.g.
>>>
>>> .../piglit/bin/amd_pinned_memory decrement-offset -auto -fbo
>>> Offset is decremented, no wait.
>>> Mesa: User error: GL_INVALID_OPERATION in glBufferData
>>> [...]
>>> Unexpected GL error: GL_INVALID_OPERATION 0x502
>>> (Error at tests/spec/amd_pinned_memory/test.c:214)
>>> PIGLIT: {"result": "fail" }
>> But no crashes? I would have expected a NULL pointer deref if we have
>> missed call path.
> No crashes. Since a GL error is raised, my guess would be that an ioctl
> which was previously succeeding is now returning an error.
Mhm, I can reproduce the problem that userptrs doesn't work any more.
But even with the mentioned patch reverted that still doesn't work on
the tip of drm-misc-next.
Are you sure your bisecting is right? Going to keep testing.
Christian.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-06 11:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 15:19 [PATCH 1/2] drm/ttm: cleanup ttm_mem_type_manager_func.get_node interface v3 Christian König
2020-06-29 15:19 ` [PATCH 2/2] drm/ttm: make TT creation purely optional v3 Christian König
2020-08-05 16:16 ` [2/2] " Michel Dänzer
2020-08-06 7:13 ` Christian König
2020-08-06 8:01 ` Michel Dänzer
2020-08-06 8:43 ` Christian König [this message]
2020-08-06 9:05 ` Michel Dänzer
2020-08-06 9:12 ` Christian König
2020-06-29 15:43 ` [PATCH 1/2] drm/ttm: cleanup ttm_mem_type_manager_func.get_node interface v3 Ruhl, Michael J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d5809be-104d-40e8-e8bb-5186d5b565b5@amd.com \
--to=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox