dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Zhiping Zhang <zhipingz@meta.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
	Alex Williamson <alex@shazbot.org>,
	Leon Romanovsky <leon@kernel.org>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Bjorn Helgaas <helgaas@kernel.org>,
	kvm@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-pci@vger.kernel.org, netdev@vger.kernel.org,
	dri-devel@lists.freedesktop.org, Keith Busch <kbusch@kernel.org>,
	Yochai Cohen <yochai@nvidia.com>,
	Yishai Hadas <yishaih@nvidia.com>,
	Linus Torvalds <torvalds@linuxfoundation.org>
Subject: Re: [PATCH v5 0/4] vfio/dma-buf: add TPH support for peer-to-peer access
Date: Fri, 29 May 2026 09:36:00 +0200	[thread overview]
Message-ID: <8d9bb0b7-182d-4930-b683-d5d24da6b2ab@amd.com> (raw)
In-Reply-To: <CAH3zFs036sr93duQKx613pCyOYw4t0_x_TdSza1xBCaEmqijyA@mail.gmail.com>

On 5/29/26 08:34, Zhiping Zhang wrote:
...
> There's no in-tree vendor PF driver

Well I have to admit it's a bit on the edge but this sentence is a show stopper.

DMA-buf is an in kernel interface for buffer sharing between drivers and any change to it needs an in kernel driver as justification for the added complexity.

> — the device is a Meta MTIA
> accelerator managed entirely from userspace via VFIO passthrough.

When you have a complete open source driver stack which utilizes VFIO passthrough as the interface to communicate with the kernel drivers then we can eventually talk about that.

But as far as I can see without upstreaming or at least open sourcing the full stack to utilize this functionality it's a clear NAK to upstreaming this.

Regards,
Christian.


> That's why the ST has to flow through a uAPI: userspace owns the
> device and its ST table, so it's the only entity that can publish a
> meaningful value for a given dma-buf.
> 
> On the effect: the endpoint's PCIe ingress block uses the 8-bit ST as
> an in-band instruction for the incoming P2P TLP — selecting a target
> cache partition and, on writes, an in-flight operation on the data
> before it lands. The dma-buf callback keeps this opaque to the
> framework — only the producer (userspace owner of the VFIO device) and
> the consumer (endpoint block) need to interpret the value.
> 
> will include these words into v6's cover letter.
> 
> Thanks,
> Zhiping


  reply	other threads:[~2026-05-29  7:36 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 14:43 [PATCH v5 0/4] vfio/dma-buf: add TPH support for peer-to-peer access Zhiping Zhang
2026-05-26 14:43 ` [PATCH v5 1/4] PCI/TPH: expose the enabled TPH requester type Zhiping Zhang
2026-05-27 20:53   ` Alex Williamson
2026-05-28  5:35     ` Zhiping Zhang
2026-05-28  8:04       ` fengchengwen
2026-05-29  6:41         ` Zhiping Zhang
2026-05-26 14:43 ` [PATCH v5 2/4] dma-buf: add optional get_tph() callback Zhiping Zhang
2026-05-27  6:57   ` Christian König
2026-05-27 17:03   ` Alex Williamson
2026-05-26 14:43 ` [PATCH v5 3/4] vfio/pci: implement get_tph and DMA_BUF_TPH feature Zhiping Zhang
2026-05-27 18:06   ` Alex Williamson
2026-05-28  5:34     ` Zhiping Zhang
2026-05-26 14:43 ` [PATCH v5 4/4] RDMA/mlx5: get tph for p2p access when registering dma-buf mr Zhiping Zhang
2026-05-27 19:00   ` Alex Williamson
2026-05-28  5:54     ` Zhiping Zhang
2026-05-27 22:55   ` Michael Gur
2026-05-28  6:07     ` Zhiping Zhang
2026-05-27  6:55 ` [PATCH v5 0/4] vfio/dma-buf: add TPH support for peer-to-peer access Christian König
2026-05-27 12:14   ` Jason Gunthorpe
2026-05-27 12:23     ` Christian König
2026-05-27 12:36       ` Jason Gunthorpe
2026-05-27 12:53         ` Christian König
2026-05-28  4:55           ` Zhiping Zhang
2026-05-28  7:46             ` Christian König
2026-05-29  6:34               ` Zhiping Zhang
2026-05-29  7:36                 ` Christian König [this message]
2026-05-29 20:11                   ` Jason Gunthorpe
2026-06-01  9:59                     ` Christian König
2026-06-01 17:47                       ` Jason Gunthorpe
2026-06-01 18:17                         ` Christian König
2026-06-01 18:48                           ` Jason Gunthorpe
2026-06-02  7:14                             ` Zhiping Zhang
2026-05-29 20:31                   ` Keith Busch
2026-06-01 10:03                     ` Christian König
2026-06-01 17:50                     ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d9bb0b7-182d-4930-b683-d5d24da6b2ab@amd.com \
    --to=christian.koenig@amd.com \
    --cc=alex@shazbot.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=helgaas@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=kbusch@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=torvalds@linuxfoundation.org \
    --cc=yishaih@nvidia.com \
    --cc=yochai@nvidia.com \
    --cc=zhipingz@meta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox