From: "C, Ramalingam" <ramalingam.c@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
seanpaul@chromium.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 2/4] drm/i915: Fix platform coverage for HDCP1.4
Date: Wed, 5 Dec 2018 17:23:29 +0530 [thread overview]
Message-ID: <8f791feb-5415-3fa9-b9bd-0764478d6f96@intel.com> (raw)
In-Reply-To: <20181204191502.GN9144@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1233 bytes --]
On 12/5/2018 12:45 AM, Ville Syrjälä wrote:
> On Tue, Dec 04, 2018 at 11:37:05PM +0530, Ramalingam C wrote:
>> HDCP1.4 is enabled and validated only on GEN9+ platforms.
>>
>> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
>> Reviewed-by: Sean Paul <sean@poorly.run>
>> ---
>> drivers/gpu/drm/i915/intel_hdcp.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
>> index c16bffcce3b0..bccfb001340a 100644
>> --- a/drivers/gpu/drm/i915/intel_hdcp.c
>> +++ b/drivers/gpu/drm/i915/intel_hdcp.c
>> @@ -769,8 +769,7 @@ static void intel_hdcp_prop_work(struct work_struct *work)
>> bool is_hdcp_supported(struct drm_i915_private *dev_priv, enum port port)
>> {
>> /* PORT E doesn't have HDCP, and PORT F is disabled */
>> - return ((INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) &&
>> - !IS_CHERRYVIEW(dev_priv) && port < PORT_E);
>> + return ((INTEL_GEN(dev_priv) >= 9) && port < PORT_E);
> Drive-by: Lots of pointless parens floating around here.
kept it for readability. Perhaps overkill here. Removed them.
Thanks,
--Ram
>
>> }
>>
>> int intel_hdcp_init(struct intel_connector *connector,
>> --
>> 2.7.4
[-- Attachment #1.2: Type: text/html, Size: 2161 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-12-05 11:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 18:07 [PATCH v3 0/4] HDCP1.4 Fixes - II Ramalingam C
2018-12-04 18:07 ` [PATCH v3 1/4] drm/i915: Fix GEN9 HDCP1.4 key load process Ramalingam C
2018-12-04 18:07 ` [PATCH v3 2/4] drm/i915: Fix platform coverage for HDCP1.4 Ramalingam C
2018-12-04 19:15 ` Ville Syrjälä
2018-12-05 11:53 ` C, Ramalingam [this message]
2018-12-04 18:07 ` [PATCH v3 3/4] drm/i915: debug log for REPLY_ACK missing Ramalingam C
2018-12-04 18:07 ` [PATCH v3 4/4] drm/i915: Increase timeout for Encrypt status change Ramalingam C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f791feb-5415-3fa9-b9bd-0764478d6f96@intel.com \
--to=ramalingam.c@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox