From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD0E8C433EF for ; Tue, 1 Feb 2022 08:54:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2BE9610E6EE; Tue, 1 Feb 2022 08:54:53 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3CE2B10E70A for ; Tue, 1 Feb 2022 08:54:52 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id E38851F438FB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1643705690; bh=cX6n8y9xqw3fyjvPkbflYeNt2MpCla3htWHQ0GpzOts=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GJGaCITCXqQz2ChA2swrnHl7qatLEV8wEXtJMTwWsdv+EbNZdVsXrQaOBpKyzB/gG XFGiuUG15jZovcZOSwY+YpHwTzCfGZEqqii2d/XJ+mVOwXqhdpYQv5MKYL2VBcGZjt xWEUJXgYXAvHdUaRo0FzkyREoCsgX6ylFDKkTqOFN0Phw3Y5LFbxVXZJcZb6RRNhNP EuQD844FmkVOzuMuVbMNeZdKfhaEY+1mFpi1cx5jbZT+Ni+8xiuzFB+U9Y6J1EbwJL /mbkmWn7Ymg2Avlze52JoA1NcGLX04LY1pV3LQGSrCTWCghynYBVvCjlTnf1dU/dJF HSqOCN2bhAeVw== Message-ID: <90ec652d-6df7-3e7b-dd81-7ced053e1dcf@collabora.com> Date: Tue, 1 Feb 2022 09:54:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v11] drm/bridge: add it6505 driver Content-Language: en-US To: Robert Foss , Hsin-Yi Wang References: <20220114091502.333083-1-allen.chen@ite.com.tw> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kenneth Hung , Jau-Chih Tseng , David Airlie , allen , Hermes Wu , Neil Armstrong , open list , "open list:DRM DRIVERS" , Jonas Karlman , Jernej Skrabec , Andrzej Hajda , Hsin-Yi Wang , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Il 31/01/22 19:36, Robert Foss ha scritto: > On Mon, 31 Jan 2022 at 17:55, Hsin-Yi Wang wrote: >> >> On Tue, Feb 1, 2022 at 12:37 AM Robert Foss wrote: >>> >>> On Thu, 20 Jan 2022 at 16:25, AngeloGioacchino Del Regno >>> wrote: >>>> >>>> Il 14/01/22 10:14, allen ha scritto: >>>>> This adds support for the iTE IT6505. >>>>> This device can convert DPI signal to DP output. >>>>> >>>>> From: Allen Chen >>>>> Tested-by: Hsin-yi Wang >>>>> Signed-off-by: Hermes Wu >>>>> Signed-off-by: Allen Chen >>>>> --- >>>>> v10 -> v11 : remove drm_bridge_new_crtc_state >>>>> --- >>>>> drivers/gpu/drm/bridge/Kconfig | 8 + >>>>> drivers/gpu/drm/bridge/Makefile | 1 + >>>>> drivers/gpu/drm/bridge/ite-it6505.c | 3352 +++++++++++++++++++++++++++ >>>>> 3 files changed, 3361 insertions(+) >>>>> create mode 100644 drivers/gpu/drm/bridge/ite-it6505.c >>>>> >>>> >>>> ...snip... >>>> >>>>> +static const struct of_device_id it6505_of_match[] = { >>>>> + { .compatible = "ite,it6505" }, >>>>> + { } >>>>> +}; >>>> >>>> If you want to have a DT compatible and DT properties, you have to also add >>>> dt-bindings (yaml) for this driver, otherwise, any SoC/device DT will fail >>>> the dt binding check.... So, please, add that. >>> >>> Let me second this. A dt-binding is needed for this driver to be >>> complete, it functions as both documentation and a way to test the DTS >>> that use this device, so it is really important. >>> >> The binding seems to be accepted before the driver: >> https://elixir.bootlin.com/linux/v5.16.4/source/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > I completely missed that. In that case we're only missing the > reviewed-by tag from someone. > You have mine... the intention was to give a Reviewed-by, not a Acked-by - I'm sorry for that, I was sending more than one email and the wrong tag slipped through. So, please change my Acked-by tag to Reviewed-by: AngeloGioacchino Del Regno >> >>>> >>>> For the driver by itself, though: >>>> >>>> Acked-by: AngeloGioacchino Del Regno >>>> >>>>> + >>>>> +static struct i2c_driver it6505_i2c_driver = { >>>>> + .driver = { >>>>> + .name = "it6505", >>>>> + .of_match_table = it6505_of_match, >>>>> + .pm = &it6505_bridge_pm_ops, >>>>> + }, >>>>> + .probe = it6505_i2c_probe, >>>>> + .remove = it6505_i2c_remove, >>>>> + .shutdown = it6505_shutdown, >>>>> + .id_table = it6505_id, >>>>> +}; >>>>> + >>>>> +module_i2c_driver(it6505_i2c_driver); >>>>> + >>>>> +MODULE_AUTHOR("Allen Chen "); >>>>> +MODULE_DESCRIPTION("IT6505 DisplayPort Transmitter driver"); >>>>> +MODULE_LICENSE("GPL v2"); >>>>> >>>>