From: "Tomasz Pakuła" <tomasz.pakula.oficjalny@gmail.com>
To: Fangzhi Zuo <jerry.zuo@amd.com>,
adolfotregosa@gmail.com, harry.wentland@amd.com,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH v1 1/3] drm: Add passive_vrr properties for passive/desktop VRR
Date: Tue, 01 Sep 2026 21:28:04 +0200 [thread overview]
Message-ID: <9480a7c15ccc389120246a1403ea1860f5f05b56.camel@gmail.com> (raw)
In-Reply-To: <20260901191251.2653684-2-jerry.zuo@amd.com>
On Tue, 2026-09-01 at 15:12 -0400, Fangzhi Zuo wrote:
> Add the PASSIVE_VRR_DISABLED atomic CRTC property
Michel Dänzer already commented on this:
https://lore.kernel.org/amd-gfx/c6a852ae-4edf-4336-9f2a-448c296cc045@mailbox.org/
"Having a negation term like "disabled" in the property name can be
confusing (as it involves double negation when the property value is 0)
and is better avoided."
To this day, I'm not sure how to better handle this, without the driver
just forcing VRR on it's own. Consequently, this will enforce ALLM so
probably there is a benefit to leaving this configurable and somehow
default for HDMI.
IDK, smarter people can probably deal with this, just wanted to forward
the comments I received previously.
On windows, AMD driver just doesn't care and forces VRR signaling all
the time, without a way to disable it.
next prev parent reply other threads:[~2026-09-01 19:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 19:12 [PATCH v1 0/3] drm/amd/display: passive VRR Fangzhi Zuo
2026-09-01 19:12 ` [PATCH v1 1/3] drm: Add passive_vrr properties for passive/desktop VRR Fangzhi Zuo
2026-09-01 19:24 ` sashiko-bot
2026-09-01 19:28 ` Tomasz Pakuła [this message]
2026-09-01 19:12 ` [PATCH v1 2/3] drm/amd/display: Use passive_vrr properties in amdgpu Fangzhi Zuo
2026-09-01 19:29 ` sashiko-bot
2026-09-01 19:12 ` [PATCH v1 3/3] drm/amd/display: Keep FreeSync for HF-VSDB VRR sinks in MCCS fallback Fangzhi Zuo
2026-09-02 16:23 ` [PATCH v1 0/3] drm/amd/display: passive VRR Adolfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9480a7c15ccc389120246a1403ea1860f5f05b56.camel@gmail.com \
--to=tomasz.pakula.oficjalny@gmail.com \
--cc=adolfotregosa@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=jerry.zuo@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox