Re: [PATCH v2 30/37] drm/vboxvideo: Switch to drm_atomic_get_new_crtc_state()

[Hans de Goede <hansg@kernel.org>]

Hi,

On 2-Sep-25 11:35 AM, Maxime Ripard wrote:
> The vboxvideo atomic_check implementation uses the deprecated
> drm_atomic_get_existing_crtc_state() helper.
> 
> This hook is called as part of the global atomic_check, thus before the
> states are swapped. The existing state thus points to the new state, and
> we can use drm_atomic_get_new_crtc_state() instead.
> 
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
> 
> ---
> To: Hans de Goede <hansg@kernel.org>
> Cc: dri-devel@lists.freedesktop.org

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hansg@kernel.org>

Regards,

Hans




> ---
>  drivers/gpu/drm/vboxvideo/vbox_mode.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vboxvideo/vbox_mode.c b/drivers/gpu/drm/vboxvideo/vbox_mode.c
> index 9ff3bade979577df0bc2e6e9653b3fb8fd486062..aa0dded595b6e00a9aa2027b36ca11711ccc0439 100644
> --- a/drivers/gpu/drm/vboxvideo/vbox_mode.c
> +++ b/drivers/gpu/drm/vboxvideo/vbox_mode.c
> @@ -260,12 +260,12 @@ static int vbox_primary_atomic_check(struct drm_plane *plane,
>  	struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state,
>  									   plane);
>  	struct drm_crtc_state *crtc_state = NULL;
>  
>  	if (new_state->crtc) {
> -		crtc_state = drm_atomic_get_existing_crtc_state(state,
> -								new_state->crtc);
> +		crtc_state = drm_atomic_get_new_crtc_state(state,
> +							   new_state->crtc);
>  		if (WARN_ON(!crtc_state))
>  			return -EINVAL;
>  	}
>  
>  	return drm_atomic_helper_check_plane_state(new_state, crtc_state,
> @@ -342,12 +342,12 @@ static int vbox_cursor_atomic_check(struct drm_plane *plane,
>  	u32 width = new_state->crtc_w;
>  	u32 height = new_state->crtc_h;
>  	int ret;
>  
>  	if (new_state->crtc) {
> -		crtc_state = drm_atomic_get_existing_crtc_state(state,
> -								new_state->crtc);
> +		crtc_state = drm_atomic_get_new_crtc_state(state,
> +							   new_state->crtc);
>  		if (WARN_ON(!crtc_state))
>  			return -EINVAL;
>  	}
>  
>  	ret = drm_atomic_helper_check_plane_state(new_state, crtc_state,
>