From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH v8 2/4] drm: Add API for capturing frame CRCs Date: Tue, 4 Oct 2016 13:38:35 +0100 Message-ID: <960a3dc0-173d-e0ca-d56d-be468b8b5926@nvidia.com> References: <1473415010-1389-1-git-send-email-tomeu.vizoso@collabora.com> <1473415010-1389-3-git-send-email-tomeu.vizoso@collabora.com> <48ef75ce-061f-d9b0-d5fb-4503af2e5f71@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Daniel Vetter Cc: Tomeu Vizoso , Linux Kernel Mailing List , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jonathan Corbet , Emil Velikov , dri-devel , Daniel Vetter , Thierry Reding , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Alexandre Courbot List-Id: dri-devel@lists.freedesktop.org On 04/10/16 12:25, Daniel Vetter wrote: > On Tue, Oct 4, 2016 at 12:10 PM, Jon Hunter wrote: >> Looks like crtc is a errno in the above case. I see this function is >> called by looping through all the crtc and we never check to see if >> they are valid. Should we? > > Tegra is still using the load/unload hooks. That didn't mesh well with > Tomeu's patches (and Tomeu's patches have been thrown out meanwhile > because of that). Still would be neat if tegra could be demidlayered > and loose it's load/unload hooks. See the kerneldoc in drm_drv.c > (especially the DOC: section). Adding Thierry and Alex as this is more their domain and CC'ing linux-tegra. Cheers Jon -- nvpublic