dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Wachowski, Karol" <karol.wachowski@linux.intel.com>
To: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Cc: oded.gabbay@gmail.com, jeff.hugo@oss.qualcomm.com,
	lizhi.hou@amd.com, andrzej.kacprowski@linux.intel.com
Subject: Re: [PATCH v2 0/3] accel/ivpu: Harden parsing of firmware-shared buffers
Date: Mon, 7 Sep 2026 08:13:39 +0200	[thread overview]
Message-ID: <96771f7b-e3cd-44b3-921d-9d8e8bc1a5fa@linux.intel.com> (raw)
In-Reply-To: <20260901125749.404338-1-dawid.osuchowski@linux.intel.com>

On 01-Sep-26 14:57, Dawid Osuchowski wrote:
> The IPC and firmware tracing buffers live in memory shared with the NPU
> firmware, so every field the host reads from them is untrusted input.
> This series fixes places where the host trusted such input and could
> end up dereferencing addresses outside the underlying BO.
> 
> All patches are tagged for stable.
> 
> Changes since v1:
>   - Added a new patch ("accel/ivpu: Limit firmware log name prints to
>     field size") after Sashiko pointed out that log->name was still being
>     printed with an unbounded "%s" conversion. The field is fixed-size
>     and expected to be NUL-terminated, but a firmware bug could drop the
>     terminator; harden the host against that case.
>   - No changes to the other two patches.
> 
> Dawid Osuchowski (1):
>    accel/ivpu: Limit firmware log name prints to field size
> 
> Magdalena Schulfer (2):
>    accel/ivpu: Validate full buffer range in ivpu_to_cpu_addr
>    accel/ivpu: Validate firmware log buffer metadata
> 
>   drivers/accel/ivpu/ivpu_fw_log.c | 87 +++++++++++++++++++-------------
>   drivers/accel/ivpu/ivpu_gem.h    | 14 +++--
>   drivers/accel/ivpu/ivpu_ipc.c    |  7 +--
>   3 files changed, 67 insertions(+), 41 deletions(-)
> 

Thanks,
Applied to drm-misc-fixes.

Karol

      parent reply	other threads:[~2026-09-07  6:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 12:57 [PATCH v2 0/3] accel/ivpu: Harden parsing of firmware-shared buffers Dawid Osuchowski
2026-09-01 12:57 ` [PATCH v2 1/3] accel/ivpu: Validate full buffer range in ivpu_to_cpu_addr Dawid Osuchowski
2026-09-02 12:56   ` Wachowski, Karol
2026-09-01 12:57 ` [PATCH v2 2/3] accel/ivpu: Validate firmware log buffer metadata Dawid Osuchowski
2026-09-02 12:57   ` Wachowski, Karol
2026-09-01 12:57 ` [PATCH v2 3/3] accel/ivpu: Limit firmware log name prints to field size Dawid Osuchowski
2026-09-01 13:19   ` sashiko-bot
2026-09-02 12:58   ` Wachowski, Karol
2026-09-07  6:13 ` Wachowski, Karol [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96771f7b-e3cd-44b3-921d-9d8e8bc1a5fa@linux.intel.com \
    --to=karol.wachowski@linux.intel.com \
    --cc=andrzej.kacprowski@linux.intel.com \
    --cc=dawid.osuchowski@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jeff.hugo@oss.qualcomm.com \
    --cc=lizhi.hou@amd.com \
    --cc=oded.gabbay@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox