From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EE5FC433F5 for ; Thu, 27 Jan 2022 12:10:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B6E3310EFD8; Thu, 27 Jan 2022 12:10:42 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C1B610EFDE; Thu, 27 Jan 2022 12:10:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643285441; x=1674821441; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=AibxP2rY4gvSIjx0khmbPqnlOiHnIYEpnzKovXuUJ9o=; b=ZvknTpU4G9Hq9zzrWFM92L58wFMIQJMWW8K5C80wzN6snKLXvksD7TWE JXBRJNaZad3SOyRjdTBhKiYDE7mH1TPK6cylC4d2nahVlScXVI8FnsOH1 SPbsMPZFn/sZw78QIcl5A16EBdFWkpKKQku60qWZA36AaD2bq1ZMnjXK3 oZo8lU8SpWLHKjJlDg3KFxJ5iWsBv6XGCbsHsus95WBiYtbn/Mu5peezc eAEy2a8iuWxMXh52SpP/dDxeOBg5rfw+9HxSe5xbjwDX1H7psc/6lMBMx n+xTGKd5pMY9Es4Q1zo+/Mvyj2yGy0FrNsdgZbLJUPL4MnSb945EQzwFJ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10239"; a="307545127" X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="307545127" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 04:10:20 -0800 X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="480268226" Received: from cmathias-mobl1.ger.corp.intel.com (HELO [10.249.254.207]) ([10.249.254.207]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 04:10:18 -0800 Message-ID: <982820d1-0d9a-ac01-e4f5-9a11556d8690@linux.intel.com> Date: Thu, 27 Jan 2022 13:09:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2. Content-Language: en-US From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= To: Maarten Lankhorst , Gwan-gyeong Mun , intel-gfx@lists.freedesktop.org References: <20220126073703.1215696-1-maarten.lankhorst@linux.intel.com> <83aec5cf-2e5c-77ec-b716-0416551c3f2a@linux.intel.com> <27506ac8eff06662f063d563662555cb08f2ce64.camel@linux.intel.com> In-Reply-To: <27506ac8eff06662f063d563662555cb08f2ce64.camel@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 1/27/22 13:05, Thomas Hellström wrote: > >> The bug on vm_close is a separate bug, and would probably best be >> fixed in a separate patch. >> >> Could I get a r-b on this? It should fix some issues, even if the >> unbind there is a separate bug. >> >> ~Maarten >> > Recognizing that it doesn't fix the vm_close issue, > > Reviewed-by: Thomas Hellström Oh, BTW should probably carefully review those seemingly unrelated stall warnings from BAT to check whether the newly introduced object lock might stall a workqueue causing those. /Thomas >