From: Nirmoy <nirmodas@amd.com>
To: christian.koenig@amd.com, Nirmoy Das <nirmoy.aiemd@gmail.com>,
dri-devel@lists.freedesktop.org
Cc: thellstrom@vmware.com, airlied@linux.ie, kenny.ho@amd.com,
brian.welty@intel.com, amd-gfx@lists.freedesktop.org,
nirmoy.das@amd.com, linux-graphics-maintainer@vmware.com,
bskeggs@redhat.com, alexander.deucher@amd.com, sean@poorly.run,
kraxel@redhat.com
Subject: Re: [PATCH 3/7] drm/vmwgfx: don't use ttm bo->offset
Date: Mon, 17 Feb 2020 12:18:53 +0100 [thread overview]
Message-ID: <98e8a992-ceeb-3996-a2aa-99c830dde355@amd.com> (raw)
In-Reply-To: <19509316-9673-a435-6e74-ab4f43344d94@gmail.com>
On 2/17/20 12:09 PM, Christian König wrote:
> Am 17.02.20 um 11:18 schrieb Nirmoy Das:
>> Calculate GPU offset within vmwgfx driver itself without depending on
>> bo->offset
>>
>> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
>> ---
>> drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 4 ++--
>> drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +-
>> drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c | 2 +-
>> drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 2 --
>> 4 files changed, 4 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
>> b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
>> index 8b71bf6b58ef..a714582bb61c 100644
>> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
>> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
>> @@ -258,7 +258,7 @@ int vmw_bo_pin_in_start_of_vram(struct
>> vmw_private *dev_priv,
>> ret = ttm_bo_validate(bo, &placement, &ctx);
>> /* For some reason we didn't end up at the start of vram */
>> - WARN_ON(ret == 0 && bo->offset != 0);
>> + WARN_ON(ret == 0 && (bo->mem.start << PAGE_SHIFT) != 0);
>
> You could drop the (<< PAGE_SHIFT) part here.
>
Thanks Christian! I will drop that in next version.
> Apart from that feel free to stick an Acked-by: Christian König
> <christian.koenig@amd.com> on the patch.
>
> Christian.
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-17 11:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 10:18 [RFC PATCH 0/6] do not store GPU address in TTM Nirmoy Das
2020-02-17 10:18 ` [PATCH 1/7] drm/amdgpu: move ttm bo->offset to amdgpu_bo Nirmoy Das
2020-02-17 11:07 ` Christian König
2020-02-17 10:18 ` [PATCH 2/7] drm/radeon: don't use ttm bo->offset Nirmoy Das
2020-02-17 10:18 ` [PATCH 3/7] drm/vmwgfx: " Nirmoy Das
2020-02-17 11:09 ` Christian König
2020-02-17 11:18 ` Nirmoy [this message]
2020-02-17 10:18 ` [PATCH 4/7] drm/nouveau: " Nirmoy Das
2020-02-17 12:12 ` Christian König
2020-02-17 10:18 ` [PATCH 5/7] drm/qxl: " Nirmoy Das
2020-02-17 12:38 ` Gerd Hoffmann
2020-02-17 10:18 ` [PATCH 6/7] drm/bochs: " Nirmoy Das
2020-02-17 12:41 ` Gerd Hoffmann
2020-02-17 12:52 ` Nirmoy
2020-02-17 10:18 ` [PATCH 7/7] drm/ttm: do not keep GPU dependent addresses Nirmoy Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98e8a992-ceeb-3996-a2aa-99c830dde355@amd.com \
--to=nirmodas@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=brian.welty@intel.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kenny.ho@amd.com \
--cc=kraxel@redhat.com \
--cc=linux-graphics-maintainer@vmware.com \
--cc=nirmoy.aiemd@gmail.com \
--cc=nirmoy.das@amd.com \
--cc=sean@poorly.run \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox