From: Jiri Slaby <jirislaby@kernel.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
nouveau@lists.freedesktop.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Peter Rosin <peda@axentia.se>,
George Kennedy <george.kennedy@oracle.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Ben Skeggs <bskeggs@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peilin Ye <yepeilin.cs@gmail.com>
Subject: Re: [PATCH] fbcon: Disable accelerated scrolling
Date: Thu, 29 Oct 2020 06:42:39 +0100 [thread overview]
Message-ID: <997267e5-40c1-2aaf-235a-ff14f2d101e6@kernel.org> (raw)
In-Reply-To: <20201028160600.3752105-1-daniel.vetter@ffwll.ch>
On 28. 10. 20, 17:06, Daniel Vetter wrote:
> So ever since syzbot discovered fbcon, we have solid proof that it's
> full of bugs. And often the solution is to just delete code and remove
> features, e.g. 50145474f6ef ("fbcon: remove soft scrollback code").
...
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -1147,11 +1147,13 @@ static void fbcon_init(struct vc_data *vc, int init)
>
> ops->graphics = 0;
>
> - if ((cap & FBINFO_HWACCEL_COPYAREA) &&
> - !(cap & FBINFO_HWACCEL_DISABLED))
> - p->scrollmode = SCROLL_MOVE;
> - else /* default to something safe */
> - p->scrollmode = SCROLL_REDRAW;
> + /*
> + * No more hw acceleration for fbcon.
> + *
> + * FIXME: Garabge collect all the now dead code after sufficient time
If you go this non-invasive path, then only a nit here: "Garbage"
thanks,
--
js
suse labs
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-29 5:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 16:06 [PATCH] fbcon: Disable accelerated scrolling Daniel Vetter
2020-10-28 16:45 ` Sam Ravnborg
2020-10-28 16:48 ` Daniel Vetter
2020-10-28 16:57 ` Greg Kroah-Hartman
2020-10-28 18:50 ` Sam Ravnborg
2020-10-28 19:57 ` Daniel Vetter
2020-10-28 19:02 ` Thomas Zimmermann
2020-10-28 19:55 ` Daniel Vetter
2020-10-29 8:07 ` Thomas Zimmermann
2020-10-29 5:42 ` Jiri Slaby [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-10-29 10:14 [PATCH 1/3] " Daniel Vetter
2020-10-29 13:22 ` [PATCH] " Daniel Vetter
2020-10-30 8:30 ` Tomi Valkeinen
2020-10-30 8:52 ` Daniel Vetter
2020-10-31 10:27 ` Geert Uytterhoeven
2020-10-31 14:17 ` Daniel Vetter
2020-11-18 9:21 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=997267e5-40c1-2aaf-235a-ff14f2d101e6@kernel.org \
--to=jirislaby@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=bskeggs@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=george.kennedy@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=natechancellor@gmail.com \
--cc=nouveau@lists.freedesktop.org \
--cc=peda@axentia.se \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=tomi.valkeinen@ti.com \
--cc=torvalds@linux-foundation.org \
--cc=yepeilin.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox