From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DF84C4742C for ; Mon, 2 Nov 2020 13:44:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEA872074F for ; Mon, 2 Nov 2020 13:43:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEA872074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 371F36EB84; Mon, 2 Nov 2020 13:43:29 +0000 (UTC) Received: from aposti.net (aposti.net [89.234.176.197]) by gabe.freedesktop.org (Postfix) with ESMTPS id 07BA86E48E for ; Mon, 2 Nov 2020 10:19:37 +0000 (UTC) Date: Mon, 02 Nov 2020 10:19:21 +0000 From: Paul Cercueil Subject: Re: [PATCH 2/4] dt-bindings: display: Add ABT Y030XX067A =?UTF-8?Q?panel=0D=0A?= bindings To: Sam Ravnborg Message-Id: <9CZ5JQ.CWYPSJ8EDOW4@crapouillou.net> In-Reply-To: <20201101122900.GB1269759@ravnborg.org> References: <20201101093150.8071-1-paul@crapouillou.net> <20201101093150.8071-3-paul@crapouillou.net> <20201101122900.GB1269759@ravnborg.org> MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 02 Nov 2020 13:43:21 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, od@zcrc.me, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Thierry Reding , Christophe Branchereau Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Le dim. 1 nov. 2020 =E0 13:29, Sam Ravnborg a =E9crit : > On Sun, Nov 01, 2020 at 09:31:48AM +0000, Paul Cercueil wrote: >> The Asia Better Technology (ABT) Y030XX067A panel is a 3.0" 320x480 >> 24-bit IPS LCD panel. Its particularity is that it has non-square = >> pixels >> (as it is 4:3 for a resolution of 320x480), and that it requires odd >> lines to be sent as RGB and even lines to be sent as GRB on its = >> 8-bit >> bus. >> = >> Signed-off-by: Paul Cercueil >> --- >> .../display/panel/abt,y030xx067a.yaml | 54 = >> +++++++++++++++++++ >> 1 file changed, 54 insertions(+) >> create mode 100644 = >> Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml >> = >> diff --git = >> a/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml = >> b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml >> new file mode 100644 >> index 000000000000..6407e8bf45fa >> --- /dev/null >> +++ = >> b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml >> @@ -0,0 +1,54 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: = >> http://devicetree.org/schemas/display/panel/abt,y030xx067a.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Asia Better Technology 3.0" (320x480 pixels) 24-bit IPS LCD = >> panel >> + >> +description: | >> + The panel must obey the rules for a SPI slave device as = >> specified in >> + spi/spi-controller.yaml >> + >> +maintainers: >> + - Paul Cercueil >> + >> +allOf: >> + - $ref: panel-common.yaml# >> + >> +properties: >> + compatible: >> + const: abt,y030xx067a >> + >> + backlight: true >> + port: true >> + power-supply: true >> + reg: true >> + reset-gpios: true > = > The binding is missing: > required: > - compatible > - reg > - power-supply > - reset-gpios > - ... > = > additionalProperties: false > = > So r-b only with these added. Stupid mistake, sorry about that. I'll V2. -Paul > = > Sam > = >> + >> +examples: >> + - | >> + #include >> + >> + spi { >> + #address-cells =3D <1>; >> + #size-cells =3D <0>; >> + >> + panel@0 { >> + compatible =3D "abt,y030xx067a"; >> + reg =3D <0>; >> + >> + spi-max-frequency =3D <3125000>; >> + >> + reset-gpios =3D <&gpe 2 GPIO_ACTIVE_LOW>; >> + >> + backlight =3D <&backlight>; >> + power-supply =3D <&vcc>; >> + >> + port { >> + panel_input: endpoint { >> + remote-endpoint =3D <&panel_output>; >> + }; >> + }; >> + }; >> + }; >> -- >> 2.28.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel