From: Archit Taneja <architt@codeaurora.org>
To: Eric Anholt <eric@anholt.net>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/bridge: Build the panel wrapper in drm_kms_helper
Date: Wed, 7 Jun 2017 13:49:19 +0530 [thread overview]
Message-ID: <9be9f59f-3d6e-d68b-490e-68fa325a38fe@codeaurora.org> (raw)
In-Reply-To: <87fufd9f60.fsf@eliezer.anholt.net>
On 06/06/2017 11:22 PM, Eric Anholt wrote:
> Maarten Lankhorst <maarten.lankhorst@linux.intel.com> writes:
>
>> This fixes the following depmod error when building drm as a module:
>> depmod: ERROR: Found 6 modules in dependency cycles!
>> depmod: ERROR: Cycle detected: drm -> drm_kms_helper -> drm
>>
>> Fixes: 13dfc0540a57 ("drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.")
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Looks plausible to me. Given how much trouble I've had getting the
> kbuild right, anyone else want to chime in?
>
The fix looks good to me too. depmod doesn't complain after this patch.
I can queue it to drm-misc-next if no one else has any comments on it
in the next few hours or so.
I'll make sure I check with 'make module_install' before pushing, I didn't
know depmod wasn't called otherwise.
Thanks,
Archit
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-06-07 8:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 20:25 [PATCH v3] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge Eric Anholt
2017-06-05 10:08 ` Archit Taneja
2017-06-06 14:24 ` Maarten Lankhorst
2017-06-06 14:31 ` [PATCH v3] drm/bridge: Build the panel wrapper in drm_kms_helper Maarten Lankhorst
2017-06-06 17:52 ` Eric Anholt
2017-06-07 8:19 ` Archit Taneja [this message]
2017-06-07 6:55 ` Lofstedt, Marta
2017-06-06 14:42 ` [PATCH v3] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9be9f59f-3d6e-d68b-490e-68fa325a38fe@codeaurora.org \
--to=architt@codeaurora.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).