From: Tomi Valkeinen via dri-devel <dri-devel@lists.freedesktop.org>
To: Jyri Sarha <jsarha@ti.com>, dri-devel@lists.freedesktop.org
Cc: lcpd_audiovideo@list.ti.com, laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 1/2] drm/tilcdc: use drm_fbdev_generic_setup
Date: Fri, 15 Feb 2019 13:50:31 +0200 [thread overview]
Message-ID: <9c82b801-7882-e70a-6609-965d608cc18d@ti.com> (raw)
In-Reply-To: <a1cf2a08064a06d89a4a906712f6d82de605b01a.1550217735.git.jsarha@ti.com>
On 15/02/2019 10:13, Jyri Sarha wrote:
> Calling drm_fbdev_cma_fini() after drm_dev_unregister() started to
> cause a crash when unloading tilcdc some time between 4.14 and
> 4.19. Instead of changing the unload order it looks like using
> drm_fbdev_generic_setup() is the direction to go.
>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> ---
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-02-15 11:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 8:13 [PATCH 0/2] drm/tilcdc: A fix and a clean-up for tilcdc Jyri Sarha via dri-devel
2019-02-15 8:13 ` [PATCH 1/2] drm/tilcdc: use drm_fbdev_generic_setup Jyri Sarha via dri-devel
2019-02-15 11:50 ` Tomi Valkeinen via dri-devel [this message]
2019-03-06 1:23 ` Laurent Pinchart
2019-02-15 8:13 ` [PATCH 2/2] drm/tilcdc: Remove unnecessary struct tilcdc_panel_info members Jyri Sarha via dri-devel
2019-02-15 11:54 ` Tomi Valkeinen via dri-devel
2019-03-06 1:27 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c82b801-7882-e70a-6609-965d608cc18d@ti.com \
--to=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lcpd_audiovideo@list.ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox