Re: [PATCH v3] staging: vboxvideo: Add vboxvideo to drivers/staging

[Michael Thayer <michael.thayer@oracle.com>]

Hello Hans,

26.06.2017 18:06, Hans de Goede wrote:
> Hi,
> 
> On 23-06-17 11:31, Daniel Vetter wrote:
>> On Thu, Jun 22, 2017 at 11:11:37AM +0200, Hans de Goede wrote:
[vboxvideo driver submission information to staging.]
>>
>> In the end it's up to you, but our experience in drm with -staging has
>> been that's both a pain (separate tree, which makes coordination harder
>> for drm drivers) and a ghetto (no one from drm will look at your
>> patches).
>>
>> Especially for small drivers (and this is one, and I expect if you use
>> all
>> the latest and greates helpers atomic will provide it'll shrink
>> considerably) it's just not worth the pain to polish stuff twice.
>>
>> 0toh I see the benefit of putting stuff into staging so in the end
>> it's up
>> to you, just beware pls.
> 
> Thanks for the heads up Daniel, for now I would like to move forward with
> getting this in staging, but I do agree that it would be good to get it
> into drivers/gpu soon. Michael do you think you will have some time soon
> to look at moving this to the atomic helpers ?
Taking a look at that now.  There is rather a lot of deprecated API use
there that I will have to clean up first.  The ast driver which I was
tracking does not seem to have had much clean-up recently - qxl might
have been a better choice.  I will also want to get our local code at
the level of your v4 submission before I start to avoid creating
unneeded difficulties.

By the way, see a small, as yet uncommitted fix below.

Regards
Michael

Index: src/VBox/Additions/linux/drm/vbox_fb.c
===================================================================
--- src/VBox/Additions/linux/drm/vbox_fb.c	(revision 116355)
+++ src/VBox/Additions/linux/drm/vbox_fb.c	(working copy)
@@ -364,6 +364,9 @@

 	if (fbdev->helper.fbdev) {
 		info = fbdev->helper.fbdev;
+#ifdef CONFIG_FB_DEFERRED_IO
+		fb_deferred_io_cleanup(info);
+#endif
 		unregister_framebuffer(info);
 		if (info->cmap.len)
 			fb_dealloc_cmap(&info->cmap);
-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel