From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hubbard Subject: Re: [PATCH v7 02/24] mm/gup: factor out duplicate code from four routines Date: Thu, 21 Nov 2019 18:54:02 -0800 Message-ID: <9d0846af-2c4f-7cda-dfcb-1f642943afea@nvidia.com> References: <20191121071354.456618-1-jhubbard@nvidia.com> <20191121071354.456618-3-jhubbard@nvidia.com> <20191121080356.GA24784@lst.de> <852f6c27-8b65-547b-89e0-e8f32a4d17b9@nvidia.com> <20191121095411.GC18190@quack2.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9F5F86F4CC for ; Fri, 22 Nov 2019 02:56:51 +0000 (UTC) In-Reply-To: <20191121095411.GC18190@quack2.suse.cz> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jan Kara Cc: Michal Hocko , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Christoph Hellwig , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Al Viro , Dan Williams , Mauro Carvalho Chehab List-Id: dri-devel@lists.freedesktop.org T24gMTEvMjEvMTkgMTo1NCBBTSwgSmFuIEthcmEgd3JvdGU6Cj4gT24gVGh1IDIxLTExLTE5IDAw OjI5OjU5LCBKb2huIEh1YmJhcmQgd3JvdGU6Cj4+Pgo+Pj4gT3RoZXJ3aXNlIHRoaXMgbG9va3Mg ZmluZSBhbmQgbWlnaHQgYmUgYSB3b3J0aHdoaWxlIGNsZWFudXAgdG8gZmVlZAo+Pj4gQW5kcmV3 IGZvciA1LjUgaW5kZXBlbmRlbnQgb2YgdGhlIGd1dCBvZiB0aGUgY2hhbmdlcy4KPj4+Cj4+PiBS ZXZpZXdlZC1ieTogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBsc3QuZGU+Cj4+Pgo+Pgo+PiBUaGFu a3MgZm9yIHRoZSByZXZpZXdzISBTYXksIGl0IHNvdW5kcyBsaWtlIHlvdXIgdmlldyBoZXJlIGlz IHRoYXQgdGhpcwo+PiBzZXJpZXMgc2hvdWxkIGJlIHRhcmdldGVkIGF0IDUuNiAobm90IDUuNSks IGlzIHRoYXQgd2hhdCB5b3UgaGF2ZSBpbiBtaW5kPwo+PiBBbmQgZ2V0IHRoZSBwcmVwYXJhdG9y eSBwYXRjaGVzICgxLTksIGFuZCBtYXliZSBldmVuIDEwLTE2KSBpbnRvIDUuNT8KPiAKPiBPbmUg bW9yZSBub3RlIDopIElmIHlvdSBhcmUgZ29pbmcgdG8gcHVzaCBwaW5fdXNlcl9wYWdlcygpIGlu dGVyZmFjZXMKPiAod2hpY2ggSSdtIGZpbmUgd2l0aCksIGl0IHdvdWxkIHByb2JhYmx5IG1ha2Ug c2Vuc2UgdG8gcHVzaCBhbHNvIHRoZQo+IHB1dF91c2VyX3BhZ2VzKCkgLT4gdW5waW5fdXNlcl9w YWdlcygpIHJlbmFtaW5nIHNvIHRoYXQgdGhhdCBpbmNvbnNpc3RlbmN5Cj4gaW4gbmFtaW5nIGRv ZXMgbm90IGV4aXN0IGluIHRoZSByZWxlYXNlZCB1cHN0cmVhbSBrZXJuZWwuCj4gCj4gCQkJCQkJ CQlIb256YQoKWWVzLCB0aGF0J3Mgd2hhdCB0aGlzIHBhdGNoIHNlcmllcyBkb2VzLiBCdXQgSSdt IG5vdCBzdXJlIGlmICJwdXNoIiBoZXJlCm1lYW5zLCAicHVzaCBvdXQ6IGRlZmVyIHRvIDUuNiIs ICJwdXNoIChub3cpIGludG8gNS41Iiwgb3IgImFkdm9jYXRlIGZvciI/CgpJIHdpbGwgbm90ZSB0 aGF0IGl0J3Mgbm90IGdvaW5nIHRvIGJlIGVhc3kgdG8gcmVuYW1lIGluIG9uZSBzdGVwLCBub3cK dGhhdCB0aGlzIGlzIGJlaW5nIHNwbGl0IHVwLiBCZWNhdXNlIHZhcmlvdXMgcHV0X3VzZXJfcGFn ZXMoKS1iYXNlZCBpdGVtcwphcmUgZ29pbmcgaW50byA1LjUgdmlhIGRpZmZlcmVudCBtYWludGFp bmVyIHRyZWVzIG5vdy4gUHJvYmFibHkgSSdkIG5lZWQKdG8gaW50cm9kdWNlIHVucGluX3VzZXJf cGFnZSgpIGFsb25nc2lkZSBwdXRfdXNlcl9wYWdlKCkuLi50aG91Z2h0cz8KCnRoYW5rcywKLS0g CkpvaG4gSHViYmFyZApOVklESUEKICAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED724C432C0 for ; Fri, 22 Nov 2019 02:56:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6402204FD for ; Fri, 22 Nov 2019 02:56:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6402204FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D213E6F4CC; Fri, 22 Nov 2019 02:56:52 +0000 (UTC) Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9F5F86F4CC for ; Fri, 22 Nov 2019 02:56:51 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 21 Nov 2019 18:56:52 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 21 Nov 2019 18:56:51 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 21 Nov 2019 18:56:51 -0800 Received: from [10.2.168.213] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 22 Nov 2019 02:56:50 +0000 Subject: Re: [PATCH v7 02/24] mm/gup: factor out duplicate code from four routines To: Jan Kara References: <20191121071354.456618-1-jhubbard@nvidia.com> <20191121071354.456618-3-jhubbard@nvidia.com> <20191121080356.GA24784@lst.de> <852f6c27-8b65-547b-89e0-e8f32a4d17b9@nvidia.com> <20191121095411.GC18190@quack2.suse.cz> From: John Hubbard X-Nvconfidentiality: public Message-ID: <9d0846af-2c4f-7cda-dfcb-1f642943afea@nvidia.com> Date: Thu, 21 Nov 2019 18:54:02 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191121095411.GC18190@quack2.suse.cz> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1574391412; bh=qs/HIaIDAchvyMkQnxvFfFcxB81lObthoFNUVM9HFsU=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=ea5W7/2c5vGNy7OLObdGvq5o0IpGBD08qzI9LgcD4V8BzKvR7hLDcVgsFBzIPWltE d8PXmpt/WgSDLuhJB1bSFzEA5jjhwY4dlcU7E+jQRx3TB5rkLOwlZyYegEL3tsBCr8 8qN6mxRQSSTP+FNbJyR7Zo1HLIMkYFYKo0hlXeg0mt5hFKo6iVEhrdf4E8SgIeOW2y us/ORlXUDHvqcnaCH9l42SZAxDz+ZaaZrH8tpmFx0pDTmT79WYa//P0TZxa1PMT2Ec 60tYwrFVvqZaHos2D7eAOKA1eeY7xDL9USjPj3cYeVVtnic4Fxyow9kLNCXK7YejUg or0Rt6li4HM5w== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Christoph Hellwig , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , "Aneesh Kumar K . V" , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191122025402.xH6V8RAtK6bgJ8h-bC2DtVbImyzkoEjlmtmeFzy-5Fw@z> T24gMTEvMjEvMTkgMTo1NCBBTSwgSmFuIEthcmEgd3JvdGU6Cj4gT24gVGh1IDIxLTExLTE5IDAw OjI5OjU5LCBKb2huIEh1YmJhcmQgd3JvdGU6Cj4+Pgo+Pj4gT3RoZXJ3aXNlIHRoaXMgbG9va3Mg ZmluZSBhbmQgbWlnaHQgYmUgYSB3b3J0aHdoaWxlIGNsZWFudXAgdG8gZmVlZAo+Pj4gQW5kcmV3 IGZvciA1LjUgaW5kZXBlbmRlbnQgb2YgdGhlIGd1dCBvZiB0aGUgY2hhbmdlcy4KPj4+Cj4+PiBS ZXZpZXdlZC1ieTogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBsc3QuZGU+Cj4+Pgo+Pgo+PiBUaGFu a3MgZm9yIHRoZSByZXZpZXdzISBTYXksIGl0IHNvdW5kcyBsaWtlIHlvdXIgdmlldyBoZXJlIGlz IHRoYXQgdGhpcwo+PiBzZXJpZXMgc2hvdWxkIGJlIHRhcmdldGVkIGF0IDUuNiAobm90IDUuNSks IGlzIHRoYXQgd2hhdCB5b3UgaGF2ZSBpbiBtaW5kPwo+PiBBbmQgZ2V0IHRoZSBwcmVwYXJhdG9y eSBwYXRjaGVzICgxLTksIGFuZCBtYXliZSBldmVuIDEwLTE2KSBpbnRvIDUuNT8KPiAKPiBPbmUg bW9yZSBub3RlIDopIElmIHlvdSBhcmUgZ29pbmcgdG8gcHVzaCBwaW5fdXNlcl9wYWdlcygpIGlu dGVyZmFjZXMKPiAod2hpY2ggSSdtIGZpbmUgd2l0aCksIGl0IHdvdWxkIHByb2JhYmx5IG1ha2Ug c2Vuc2UgdG8gcHVzaCBhbHNvIHRoZQo+IHB1dF91c2VyX3BhZ2VzKCkgLT4gdW5waW5fdXNlcl9w YWdlcygpIHJlbmFtaW5nIHNvIHRoYXQgdGhhdCBpbmNvbnNpc3RlbmN5Cj4gaW4gbmFtaW5nIGRv ZXMgbm90IGV4aXN0IGluIHRoZSByZWxlYXNlZCB1cHN0cmVhbSBrZXJuZWwuCj4gCj4gCQkJCQkJ CQlIb256YQoKWWVzLCB0aGF0J3Mgd2hhdCB0aGlzIHBhdGNoIHNlcmllcyBkb2VzLiBCdXQgSSdt IG5vdCBzdXJlIGlmICJwdXNoIiBoZXJlCm1lYW5zLCAicHVzaCBvdXQ6IGRlZmVyIHRvIDUuNiIs ICJwdXNoIChub3cpIGludG8gNS41Iiwgb3IgImFkdm9jYXRlIGZvciI/CgpJIHdpbGwgbm90ZSB0 aGF0IGl0J3Mgbm90IGdvaW5nIHRvIGJlIGVhc3kgdG8gcmVuYW1lIGluIG9uZSBzdGVwLCBub3cK dGhhdCB0aGlzIGlzIGJlaW5nIHNwbGl0IHVwLiBCZWNhdXNlIHZhcmlvdXMgcHV0X3VzZXJfcGFn ZXMoKS1iYXNlZCBpdGVtcwphcmUgZ29pbmcgaW50byA1LjUgdmlhIGRpZmZlcmVudCBtYWludGFp bmVyIHRyZWVzIG5vdy4gUHJvYmFibHkgSSdkIG5lZWQKdG8gaW50cm9kdWNlIHVucGluX3VzZXJf cGFnZSgpIGFsb25nc2lkZSBwdXRfdXNlcl9wYWdlKCkuLi50aG91Z2h0cz8KCnRoYW5rcywKLS0g CkpvaG4gSHViYmFyZApOVklESUEKICAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVs