From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Subject: Re: [PATCH] drm/amd/display: Disallow enabling CRTC without primary plane with FB Date: Thu, 19 Apr 2018 09:43:56 +0200 Message-ID: <9e38b52d-9e9b-b4df-e5bb-9bda1862c18a@daenzer.net> References: <20180418202647.25532-1-harry.wentland@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180418202647.25532-1-harry.wentland-5C7GfCeVMHo@public.gmane.org> Content-Language: en-CA List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Harry Wentland Cc: Bhawanpreet.Lakha-5C7GfCeVMHo@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Shirish.S-5C7GfCeVMHo@public.gmane.org List-Id: dri-devel@lists.freedesktop.org ClsgRHJvcHBpbmcgc3RhYmxlQCAoZml4ZXMgd2l0aCBDYzogc3RhYmxlIGFyZSBwaWNrZWQgdXAg Zm9yIHN0YWJsZQpicmFuY2hlcyBvbmNlIHRoZXkgbGFuZCBpbiBMaW51cycgdHJlZSwgdGhlcmUn cyBubyBwb2ludCBzZW5kaW5nIHRoZW0gdG8Kc3RhYmxlQCBkdXJpbmcgcmV2aWV3KSwgYWRkaW5n IGRyaS1kZXZlbCBdCgpPbiAyMDE4LTA0LTE4IDEwOjI2IFBNLCBIYXJyeSBXZW50bGFuZCB3cm90 ZToKPiBUaGUgYmVsb3cgY29tbWl0Cj4gCj4gICAgICJkcm0vYXRvbWljOiBUcnkgdG8gcHJlc2Vy dmUgdGhlIGNydGMgZW5hYmxlZCBzdGF0ZSBpbiBkcm1fYXRvbWljX3JlbW92ZV9mYiwgdjIiCj4g Cj4gaW50cm9kdWNlcyBhIHNsaWdodCBiZWhhdmlvcmFsIGNoYW5nZSB0byBybWZiLiBJbnN0ZWFk IG9mIGRpc2FibGluZyBhIGNydGMKPiB3aGVuIHRoZSBwcmltYXJ5IHBsYW5lIGlzIGRpc2FibGVk LCBpdCBub3cgcHJlc2VydmVzIGl0Lgo+IAo+IFNpbmNlIERDIGlzIGN1cnJlbnRseSBub3QgZXF1 aXBwZWQgdG8gaGFuZGxlIHRoaXMgd2UgbmVlZCB0byBmYWlsIHN1Y2gKPiBhIGNvbW1pdCwgb3Ro ZXJ3aXNlIHdlIG1pZ2h0IHNlZSBhIGNvcnJ1cHRlZCBzY3JlZW4uCgpIb3cgZG9lcyB0aGUgY2Fs bGVyIHJlYWN0IHRvIGZhaWxpbmcgc3VjaCBhIGNvbW1pdD8KCgo+IFRoaXMgaXMgYmFzZWQgb24g U2hpcmlzaCdzIHByZXZpb3VzIGFwcHJvYWNoIGJ1dCBhdm9pZHMgYWRkaW5nIGFsbAo+IHBsYW5l cyB0byB0aGUgbmV3IGF0b21pYyBzdGF0ZSB3aGljaCBsZWFkcyB0byBhIGZ1bGwgdXBkYXRlIGlu IERDIGZvcgo+IGFueSBjb21taXQsIGFuZCBpcyBub3Qgd2hhdCB3ZSBpbnRlbmQuCj4gCj4gVGhl b3JldGljYWxseSBETSBzaG91bGQgYmUgYWJsZSB0byBkZWFsIHdpdGggc3RhdGVzIHdpdGggZnVs bHkgcG9wdWxhdGVkIHBsYW5lcywKPiBldmVuIGZvciBzaW1wbGUgdXBkYXRlcywgc3VjaCBhcyBj dXJzb3IgdXBkYXRlcy4gVGhpcyBzaG91bGQgc3RpbGwgYmUKPiBhZGRyZXNzZWQgaW4gdGhlIGZ1 dHVyZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBIYXJyeSBXZW50bGFuZCA8aGFycnkud2VudGxhbmRA YW1kLmNvbT4KPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5jIHwgMTAgKysrKysrKysrLQo+ ICAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2Rt LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5jCj4g aW5kZXggNmY5MmExOWJlYmQ2Li4wYmRjNmI0ODRiYWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG0uYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMKPiBAQCAtNDY4Myw2ICs0 NjgzLDcgQEAgc3RhdGljIGludCBkbV91cGRhdGVfY3J0Y3Nfc3RhdGUoc3RydWN0IGFtZGdwdV9k aXNwbGF5X21hbmFnZXIgKmRtLAo+ICAJCXN0cnVjdCBhbWRncHVfZG1fY29ubmVjdG9yICphY29u bmVjdG9yID0gTlVMTDsKPiAgCQlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqbmV3X2Nvbl9z dGF0ZSA9IE5VTEw7Cj4gIAkJc3RydWN0IGRtX2Nvbm5lY3Rvcl9zdGF0ZSAqZG1fY29ubl9zdGF0 ZSA9IE5VTEw7Cj4gKwkJc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqbmV3X3BsYW5lX3N0YXRlID0g TlVMTDsKPiAgCj4gIAkJbmV3X3N0cmVhbSA9IE5VTEw7Cj4gIAo+IEBAIC00NjkwLDYgKzQ2OTEs MTMgQEAgc3RhdGljIGludCBkbV91cGRhdGVfY3J0Y3Nfc3RhdGUoc3RydWN0IGFtZGdwdV9kaXNw bGF5X21hbmFnZXIgKmRtLAo+ICAJCWRtX25ld19jcnRjX3N0YXRlID0gdG9fZG1fY3J0Y19zdGF0 ZShuZXdfY3J0Y19zdGF0ZSk7Cj4gIAkJYWNydGMgPSB0b19hbWRncHVfY3J0YyhjcnRjKTsKPiAg Cj4gKwkJbmV3X3BsYW5lX3N0YXRlID0gZHJtX2F0b21pY19nZXRfbmV3X3BsYW5lX3N0YXRlKHN0 YXRlLCBuZXdfY3J0Y19zdGF0ZS0+Y3J0Yy0+cHJpbWFyeSk7Cj4gKwo+ICsJCWlmIChuZXdfY3J0 Y19zdGF0ZS0+ZW5hYmxlICYmIG5ld19wbGFuZV9zdGF0ZSAmJiAhbmV3X3BsYW5lX3N0YXRlLT5m Yikgewo+ICsJCQlyZXQgPSAtRUlOVkFMOwo+ICsJCQlnb3RvIGZhaWw7Cj4gKwkJfQo+ICsKPiAg CQlhY29ubmVjdG9yID0gYW1kZ3B1X2RtX2ZpbmRfZmlyc3RfY3J0Y19tYXRjaGluZ19jb25uZWN0 b3Ioc3RhdGUsIGNydGMpOwo+ICAKPiAgCQkvKiBUT0RPIFRoaXMgaGFjayBzaG91bGQgZ28gYXdh eSAqLwo+IEBAIC00ODk0LDcgKzQ5MDIsNyBAQCBzdGF0aWMgaW50IGRtX3VwZGF0ZV9wbGFuZXNf c3RhdGUoc3RydWN0IGRjICpkYywKPiAgCQkJaWYgKCFkbV9vbGRfY3J0Y19zdGF0ZS0+c3RyZWFt KQo+ICAJCQkJY29udGludWU7Cj4gIAo+IC0JCQlEUk1fREVCVUdfRFJJVkVSKCJEaXNhYmxpbmcg RFJNIHBsYW5lOiAlZCBvbiBEUk0gY3J0YyAlZFxuIiwKPiArCQkJRFJNX0RFQlVHX0FUT01JQygi RGlzYWJsaW5nIERSTSBwbGFuZTogJWQgb24gRFJNIGNydGMgJWRcbiIsCj4gIAkJCQkJcGxhbmUt PmJhc2UuaWQsIG9sZF9wbGFuZV9jcnRjLT5iYXNlLmlkKTsKPiAgCj4gIAkJCWlmICghZGNfcmVt b3ZlX3BsYW5lX2Zyb21fY29udGV4dCgKPiAKCgotLSAKRWFydGhsaW5nIE1pY2hlbCBEw6RuemVy ICAgICAgICAgICAgICAgfCAgICAgICAgICAgICAgIGh0dHA6Ly93d3cuYW1kLmNvbQpMaWJyZSBz b2Z0d2FyZSBlbnRodXNpYXN0ICAgICAgICAgICAgIHwgICAgICAgICAgICAgTWVzYSBhbmQgWCBk ZXZlbG9wZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K YW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==