From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Riesen Subject: Re: [git pull] drm fixes Date: Fri, 25 Feb 2011 11:18:24 +0100 Message-ID: References: <0d30dc$l7ehaa@orsmga001.jf.intel.com> <1cced1eb38110129d097e1c8b6857d81.squirrel@webmail.greenhost.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1cced1eb38110129d097e1c8b6857d81.squirrel@webmail.greenhost.nl> Sender: linux-kernel-owner@vger.kernel.org To: Indan Zupancic Cc: Chris Wilson , Linus Torvalds , Dave Airlie , DRI mailing list , linux-kernel@vger.kernel.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org On Fri, Feb 25, 2011 at 00:29, Indan Zupancic wrote: >>> https://lkml.org/lkml/2011/2/23/34 >> >> This is just the discussion about the problem described in the ticke= t. >> It does not even mention the patch from the previous link, BTW. >> It does have the patch which returns -EINVAL for I915_PARAM_HAS_RELA= XED_FENCING, >> though. >> >> So, AFAICS, at the moment there is no better patch than this: >> >> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/= i915_dma.c >> index 17bd766..8f8a6a3 100644 >> --- a/drivers/gpu/drm/i915/i915_dma.c >> +++ b/drivers/gpu/drm/i915/i915_dma.c >> @@ -764,7 +764,7 @@ static int i915_getparam(struct drm_device *dev,= void *data, >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break; >> =C2=A0 =C2=A0 =C2=A0 case I915_PARAM_HAS_RELAXED_FENCING: >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 value =3D 1; >> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break; >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -EINVAL; >> =C2=A0 =C2=A0 =C2=A0 case I915_PARAM_HAS_COHERENT_RINGS: >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 value =3D 1; >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break; > > Read those above links again! Daniel's patch fixes that one corruptio= n, the > above snippet has the same effect and works around the same bug, but = neither > do fix that other corruption mentioned in the ticket. Do you have any idea which patch fixes what? It's just I slowly begin t= o doubt that you do. So far I found only two patches (and three changes): This is the first: Corruption caused by portions of the screen stopped updating (the Bug 2= 7572). Certainly worked around by returning -EINVAL for ..RELAXED_FENCING. The second: Corruption in small pixmaps, which has no bug number, and commented on = by Daniel in the Bug 27572 as being not the case there. =46ixed by his patch posted to dri-devel "fix corruptions on i8xx due t= o relaxed fencing". It may be related to the Bug 27572, but it certainly does not fix the problem. There is also this change from the first Daniel's patch which I don't know what to think about: diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i91= 5_gem.c index cf4f74c..2e6b532 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -1404,6 +1404,8 @@ i915_gem_get_unfenced_gtt_alignment(struct drm_i915_gem_object *obj) struct drm_device *dev =3D obj->base.dev; int tile_height; + return i915_gem_get_gtt_alignment(obj); + /* * Minimum alignment is 4k (GTT page size) for sane hw. */diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c Now, may I ask you , Indan, to shut up for while and let the developers speak? Because the matter is becoming a little bit confusing, and not w= ithout your help.