From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Airlie Subject: Re: [git pull] drm fixes Date: Wed, 23 Mar 2011 19:06:16 +1000 Message-ID: References: <1300864998.3522.71.camel@thor.local> <1300868532.3522.81.camel@thor.local> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1300868532.3522.81.camel@thor.local> Sender: linux-kernel-owner@vger.kernel.org To: =?ISO-8859-1?Q?Michel_D=E4nzer?= Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, DRI mailing list List-Id: dri-devel@lists.freedesktop.org 2011/3/23 Michel D=E4nzer : > On Mit, 2011-03-23 at 18:16 +1000, Dave Airlie wrote: >> 2011/3/23 Michel D=E4nzer : >> > On Mit, 2011-03-23 at 04:18 +0000, Dave Airlie wrote: >> >> >> >> One radeon, 2 core fixes, and an interface update to allow for > = 2 crtcs >> >> in vblank. >> > >> > [...] >> > >> >> Ilija Hadzic (1): >> >> =A0 =A0 =A0 drm/kernel: vblank wait on crtc > 1 >> > >> > This patch was still being debated yesterday, are you deliberately >> > pushing it regardless? Once it hits mainline, it'll be pretty much= set >> > in stone. >> >> From what I can see it was the userspace patches being debated, this >> one seemed fine and the interface looked okay to me. > > The author ignored my suggestions to make the patch smaller and simpl= er, > more maintainable and more future-proof all at once. It was already small and I'm not sure merging the flags made it more maintainable. Its always being a slightly painful ioctl, and hopefully any future changes add a new ioctl esp if we want 64-bit values. The only comment I really thought was necessary was changing the CAP name, but since that isn't part of the ABI (just the number) we can quickly fix it with a follow-u= p. Dave. Dave.