From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Glisse Subject: Re: Freescale Linux BSP review Date: Mon, 13 Dec 2010 11:11:19 -0500 Message-ID: References: <201012131618.04298.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-bw0-f42.google.com (mail-bw0-f42.google.com [209.85.214.42]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E7FD9E9D6 for ; Mon, 13 Dec 2010 08:11:20 -0800 (PST) Received: by bwz13 with SMTP id 13so7590529bwz.15 for ; Mon, 13 Dec 2010 08:11:19 -0800 (PST) In-Reply-To: <201012131618.04298.arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Arnd Bergmann Cc: Dave Martin , linaro-dev@lists.linaro.org, Linus Walleij , dri-devel@lists.freedesktop.org, Marcin Juszkiewicz , Jammy Zhou List-Id: dri-devel@lists.freedesktop.org On Mon, Dec 13, 2010 at 10:18 AM, Arnd Bergmann wrote: > On Monday 13 December 2010, Jammy Zhou wrote: >> On Mon, Dec 13, 2010 at 4:45 AM, Linus Walleij wrote: >> >> > On 11 December 2010 22:41, Arnd Bergmann wrote: >> > >> > * amd-gpu -- a single but huge driver for the GPU. As is normally the >> >> =A0 =A0 =A0 =A0 =A0 =A0 case with GPU drivers, we can expect long dis= cussions >> >> =A0 =A0 =A0 =A0 =A0 =A0 before it will get considered for mainline >> >> =A04 patches >> >> =A098 files changed, 278321 insertions(+), 0 deletions(-) >> >> >> > >> > Just out of curiosity, following the discussion between Dave Airlie >> > and Codeaurora this summer re GPU driver shims. >> > >> > Is the AMD GPU exposing all functionality in its kernel driver or >> > is there some userspace blob somewhere with lots of e.g. GL >> > goodies? >> > >> All the functionality for the kernel driver of AMD GPU Z430/Z160 (now >> belongs to Qualcom) is exposed. But we need accompanied userspace librar= y to >> call these functionality (buffer management, command submission, ...). > > Who owns these components? If it's closed source, the only options we > have are lobbying for complete release of the specs for a reimplementation > or reverse-engineering the drivers, which may at least get easier with > a user space driver than it would be with a kernel driver. > > Until there is a solution with an open source user space part, I would > suggest that the driver better be dropped from the Freescale BSP and > we should at least not waste time reviewing it. > > =A0 =A0 =A0 =A0Arnd >>From a quick look it also seems that the API exposed to userspace would allow easy abuse of the GPU to access any system ram. There is a reason we do expensive command checking in the other amd gpu driver (drivers/gpu/drm/radeon/*cs.c files) Cheers, Jerome