From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Airlie Subject: Re: [git pull] drm fixes Date: Fri, 25 Mar 2011 06:05:04 +1000 Message-ID: References: <1300864998.3522.71.camel@thor.local> <1300868532.3522.81.camel@thor.local> <1300880747.16522.13.camel@thor.local> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Torvalds Cc: Ilija Hadzic , =?ISO-8859-1?Q?Michel_D=E4nzer?= , linux-kernel@vger.kernel.org, DRI mailing list List-Id: dri-devel@lists.freedesktop.org On Fri, Mar 25, 2011 at 12:37 AM, Linus Torvalds wrote: > On Thu, Mar 24, 2011 at 4:31 AM, Ilija Hadzic > wrote: >> >> OK, I'll update libdrm side to match this change and send the patch later >> today > > Quite frankly, this whole discussion is a clear example of why DRM has > been problematic. > > Why the hell am I getting pushed stuff that is clearly not baked? It's > the second week of the merge window, the stuff I'm getting should have > been finalized two weeks ago, not be something that is still being > discussed and that has API issues. > > In other words: Why should I pull this at all? Linus, Take a step back, it was an enhancement to a current API, had gotten reviewed by two people when I merged it and made sense. Michel raised his concern after that point, so no matter what it was already in a tree I'd pushed out to public so the only answer when he raised his concern was to revert or fix it. Its a minor problem. Like I'd have pushed this patch post merge window, it solves a real problem that Ilija was seeing and he stepped up and fixed it, post-merge review is what happened here, and really this is nothing compared to say the fallout in the VFS after 2.6.38-rc1. If you think this has anything to do with Intel's ability to break your hardware on every merge then you've got your wires crossed. Dave.