From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5060C4338F for ; Fri, 30 Jul 2021 09:45:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 966C560F00 for ; Fri, 30 Jul 2021 09:45:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 966C560F00 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0307A6E28B; Fri, 30 Jul 2021 09:45:34 +0000 (UTC) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 71FA36E28B for ; Fri, 30 Jul 2021 09:45:33 +0000 (UTC) Received: by mail-qv1-xf31.google.com with SMTP id m12so4235833qvt.1 for ; Fri, 30 Jul 2021 02:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZpP6fJ5qS4z9U5Mk/yGz9pYoYzJS2iFy7VnajEmatcg=; b=jpGwQ3MOZMKdioaOV5hA5tHyKgYIO9urmn/aw0qWsrlXO7I81+PIfSCA+9NM5nvoZU oLwxxOscaPNPRKhu4KENjr2qgaGOkfU6NlyqsrRmHOLQFwS9YwUMh9taPwxh2uKfx/54 wj+Wa+5TX8DtPzflkIN7xLjawS33skikaknuTVp2fI39yMm52dTX9BhrVOg9bdCVRnIc l/FSUm3vwzzuVvSqvXBqrloAW9PkuV7gZEVzSd7SAiLaPKBN7HD8RSwUbvItfPO9d2W9 F/ClPcW279D2Q16uV6s+bwTuZ9bgYbTn1r6o0zIuKZxKjhsr2fiG319/Fp03gVy7vTsL e1rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZpP6fJ5qS4z9U5Mk/yGz9pYoYzJS2iFy7VnajEmatcg=; b=cNVQAOuKDM1jOaoYPbK831T1JHEA/6kOKIhwkgJ8SV+lfNnKjc1YOC1slJI9Ea6FFq 7tGySWtkXlBauHRUssDTGhfm30TRC0WRWW56BIdWMSSqmP0SFesgY8L/GpOZ5U1Pn2bm wMSb9MkmYA2Vn1ymLvigSro39Kz9pA8iCKpZPrdp9zk/oKZhUmS76aWQ96KKNyUv0FAm GQcizfCNn0cKuw+RCXJ9hzQC+aPbZ+d3JxkSGnCFiSY1g2ABBs1R+C3Jfi09phtCS6lP w7ZeHjAiE78ZwneMXLy5Q+OtddBxdGui0E2hx9nE6jywKBTcBGYMKCfEL0GEgvuvGusV JaPg== X-Gm-Message-State: AOAM533+lpf9PRPIvltuRRP1pWvZzcGGA+U/TQ0dtetHvLNngWXgf6wH xgunC00nq+YrTkOUMZaeoubNfrsMBceKt/xy/RHLMI+Rb3Y= X-Google-Smtp-Source: ABdhPJw0YuA+LbmSP5phGohjXTllv6VPDLme3t9Ljod597Ufo8L1db10TQjQfGLo2cduBjgCa+Je8+K1qzv/6zpWAlo= X-Received: by 2002:a05:6214:1882:: with SMTP id cx2mr1874675qvb.2.1627638332568; Fri, 30 Jul 2021 02:45:32 -0700 (PDT) MIME-Version: 1.0 References: <20210730061301.32492-1-zhaoxiao@uniontech.com> In-Reply-To: <20210730061301.32492-1-zhaoxiao@uniontech.com> From: Dmitry Baryshkov Date: Fri, 30 Jul 2021 12:45:21 +0300 Message-ID: Subject: Re: [PATCH] drm:This patch fixes the checkpatch.pl error to msm_drv.c To: zhaoxiao Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno , David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 30 Jul 2021 at 09:13, zhaoxiao wrote: > > ERROR: do not initialise statics to false > > Signed-off-by: zhaoxiao Could you please resend this patch following the style of the rest of patches being submitted to this area? Subject, more detailed patch description, etc. > --- > drivers/gpu/drm/msm/msm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 9b8fa2ad0d84..d9ca4bc9620b 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -59,7 +59,7 @@ static const struct drm_mode_config_helper_funcs mode_config_helper_funcs = { > }; > > #ifdef CONFIG_DRM_MSM_REGISTER_LOGGING > -static bool reglog = false; > +static bool reglog; > MODULE_PARM_DESC(reglog, "Enable register read/write logging"); > module_param(reglog, bool, 0600); > #else > @@ -76,7 +76,7 @@ static char *vram = "16m"; > MODULE_PARM_DESC(vram, "Configure VRAM size (for devices without IOMMU/GPUMMU)"); > module_param(vram, charp, 0); > > -bool dumpstate = false; > +bool dumpstate; > MODULE_PARM_DESC(dumpstate, "Dump KMS state on errors"); > module_param(dumpstate, bool, 0600); > > -- > 2.20.1 > > > -- With best wishes Dmitry