dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/nouveau: remove limit on gart
@ 2013-06-17 13:09 Maarten Lankhorst
  2013-06-17 23:48 ` Ben Skeggs
  0 siblings, 1 reply; 2+ messages in thread
From: Maarten Lankhorst @ 2013-06-17 13:09 UTC (permalink / raw)
  To: nouveau@lists.freedesktop.org; +Cc: dri-devel@lists.freedesktop.org

Most graphics cards nowadays have a multiple of this limit as their vram, so
limiting GART doesn't seem to make much sense.

Signed-off-by: Maarten >Lnkhorst <maarten.lankhorst@canonical.com>
---
diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c
index 3a5e19a..41ddecd 100644
--- a/drivers/gpu/drm/nouveau/nouveau_ttm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c
@@ -168,9 +168,6 @@ nouveau_gart_manager_new(struct ttm_mem_type_manager *man,
 	struct nouveau_bo *nvbo = nouveau_bo(bo);
 	struct nouveau_mem *node;
 
-	if (unlikely((mem->num_pages << PAGE_SHIFT) >= 512 * 1024 * 1024))
-		return -ENOMEM;
-
 	node = kzalloc(sizeof(*node), GFP_KERNEL);
 	if (!node)
 		return -ENOMEM;
@@ -406,8 +403,6 @@ nouveau_ttm_init(struct nouveau_drm *drm)
 	/* GART init */
 	if (drm->agp.stat != ENABLED) {
 		drm->gem.gart_available = nouveau_vmmgr(drm->device)->limit;
-		if (drm->gem.gart_available > 512 * 1024 * 1024)
-			drm->gem.gart_available = 512 * 1024 * 1024;
 	} else {
 		drm->gem.gart_available = drm->agp.size;
 	}

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/nouveau: remove limit on gart
  2013-06-17 13:09 [PATCH] drm/nouveau: remove limit on gart Maarten Lankhorst
@ 2013-06-17 23:48 ` Ben Skeggs
  0 siblings, 0 replies; 2+ messages in thread
From: Ben Skeggs @ 2013-06-17 23:48 UTC (permalink / raw)
  To: Maarten Lankhorst
  Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org

On Mon, Jun 17, 2013 at 11:09 PM, Maarten Lankhorst
<maarten.lankhorst@canonical.com> wrote:
> Most graphics cards nowadays have a multiple of this limit as their vram, so
> limiting GART doesn't seem to make much sense.
Pushed, thanks :)

>
> Signed-off-by: Maarten >Lnkhorst <maarten.lankhorst@canonical.com>
> ---
> diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c
> index 3a5e19a..41ddecd 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c
> @@ -168,9 +168,6 @@ nouveau_gart_manager_new(struct ttm_mem_type_manager *man,
>         struct nouveau_bo *nvbo = nouveau_bo(bo);
>         struct nouveau_mem *node;
>
> -       if (unlikely((mem->num_pages << PAGE_SHIFT) >= 512 * 1024 * 1024))
> -               return -ENOMEM;
> -
>         node = kzalloc(sizeof(*node), GFP_KERNEL);
>         if (!node)
>                 return -ENOMEM;
> @@ -406,8 +403,6 @@ nouveau_ttm_init(struct nouveau_drm *drm)
>         /* GART init */
>         if (drm->agp.stat != ENABLED) {
>                 drm->gem.gart_available = nouveau_vmmgr(drm->device)->limit;
> -               if (drm->gem.gart_available > 512 * 1024 * 1024)
> -                       drm->gem.gart_available = 512 * 1024 * 1024;
>         } else {
>                 drm->gem.gart_available = drm->agp.size;
>         }
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-06-17 23:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-17 13:09 [PATCH] drm/nouveau: remove limit on gart Maarten Lankhorst
2013-06-17 23:48 ` Ben Skeggs

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).