From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19179C83F26 for ; Tue, 29 Jul 2025 13:40:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 66BCF10E00E; Tue, 29 Jul 2025 13:40:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="k67GQX+y"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id D23CC10E00E for ; Tue, 29 Jul 2025 13:40:14 +0000 (UTC) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56T9cHaP029390 for ; Tue, 29 Jul 2025 13:40:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:reply-to:subject:to; s= qcppdkim1; bh=HLQ2yUgG0gFIFURD76i4Mqz/jV+uThgccL9ep7CGuxI=; b=k6 7GQX+yLg6ftc4AUhslhPJ/bzpJSeGBK4cIhSIKmHQGil9vtARXhgDZPJGxMXmuGC sMY4lnFuSjZYQ+aiYIUjngUi9JtW7pYQWU02fvjE6jEoDzl5cg81WjIsX7iNK5Zv WLvHBSRBgiEIhzdZk+hVclfIs4vcwqsYwZq95ij0m4/+BnURhjslpGP/ym5ykHNi Y35ut2bmqB+JCIZP2lYWPTPCC44T0r9PSrmhDvScS/8IUaLGxhNCjbdnlgNtK7lr 3CIvauZabbUGs1vauPChnIkCdlOr+FKV5XbuFw6ZuPZWph6pVFTt9B51PkRxXLYO WgneYO33PsSnS3ixK1jw== Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484qda06vf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 29 Jul 2025 13:40:13 +0000 (GMT) Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-41b398d3704so6741960b6e.0 for ; Tue, 29 Jul 2025 06:40:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753796413; x=1754401213; h=content-transfer-encoding:cc:to:subject:message-id:date:from :reply-to:in-reply-to:references:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=HLQ2yUgG0gFIFURD76i4Mqz/jV+uThgccL9ep7CGuxI=; b=MJC0MzTJKTPBc1/OHHoLL/stqJZABsS2rhTDIZpAFQ52EETEXgA81rxIeXZPuVWhRS S8lpwfvTHEw6aYW9Zt6XJ7WVlrlbOO9XKExMFrRNjmEe+cpjjzHIuNCO+gVfG8LszHju eYP605W6vuTksvmJi5zSXJ4H3YK6LuggZa5eMp40vBI00tqrjKG1665yVfRYeHoLODQe Gxr1breoh4Z6P9gmqIhNrGlYt5x7dvaRMVo4XSLoheiDiAJTCU8wS1hR7u79GUZU1upL xiFynkVytsko9UvBTKdzKsztpD7X6iNDWA+vsd8+Ypfbpjt7jPP9XpOxqecTYTycB6dF MLtw== X-Gm-Message-State: AOJu0YyAPSUayTDlteskxKPZYvo3hlm6Sy3tniWA+jqPpe8qWV+Qablk lBUN8BdiJQB82tZBFQL291mkamoJC0rDLgpXOulBHIWuo+qMngzl+IQrKBP2TsFdIYOLLDdRr0P d8uQ+VVbnIAYdtjKTPUv/BUqn+7hCM7SaTfdwVhjMed+Xe6QbQpV1ac8AUITmHSxz5NtJUbfu0S KxJ3b3dR0g3xcx2sepRUuuSaeJUutqPXh4vm/m1VoYKZ+ZQw== X-Gm-Gg: ASbGncuvwriN/e1neqh5WLFho5C3tdvLQhxKNKLn+tuvc00VwQ8907SDl83UwaQMMpn pfNiHFYjy+1F7Qa4WL1vOnHet+NHMZQn6o5ILj25EBudf7ud13VFUUi0c6QZv9ErEdkTKMXZwJQ QmoeZnLFc+BmV1KOMt46FsROnetTFm+/scsHBBjkVvBL5CZLNY9MhU X-Received: by 2002:a05:6808:6801:b0:404:dad4:f971 with SMTP id 5614622812f47-42bb972a2e3mr9290693b6e.33.1753796412974; Tue, 29 Jul 2025 06:40:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqf4clMcdqT5vWJ+nvIVIeCHsaCdP9DQ2Xz98Wpurg/ABYUj+EgAD19sV+SQb892Lv/ifuAOnr9etFXbN2drw= X-Received: by 2002:a05:6808:6801:b0:404:dad4:f971 with SMTP id 5614622812f47-42bb972a2e3mr9290665b6e.33.1753796412292; Tue, 29 Jul 2025 06:40:12 -0700 (PDT) MIME-Version: 1.0 References: <20250728203412.22573-1-robin.clark@oss.qualcomm.com> <20250728203412.22573-2-robin.clark@oss.qualcomm.com> In-Reply-To: From: Rob Clark Date: Tue, 29 Jul 2025 06:40:01 -0700 X-Gm-Features: Ac12FXx6wa3mBL8aH-OOfMIc4b5Q0MeA9kQw7eyuD2mIfr3Ns8qFmq3Be1tUb5g Message-ID: Subject: Re: [PATCH 1/7] drm/msm: Add missing "location"s to devcoredump To: Connor Abbott Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: OyDn_u9m3ShCeBzDbE6tHCnZUxpuI-Ia X-Authority-Analysis: v=2.4 cv=Pfv/hjhd c=1 sm=1 tr=0 ts=6888cf3d cx=c_pps a=yymyAM/LQ7lj/HqAiIiKTw==:117 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=0I_rIkXGDByXq9DAmH4A:9 a=QEXdDO2ut3YA:10 a=efpaJB4zofY2dbm2aIRb:22 X-Proofpoint-GUID: OyDn_u9m3ShCeBzDbE6tHCnZUxpuI-Ia X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzI5MDEwNCBTYWx0ZWRfX1Gc5aYQh9TIz T9mUUW+cBxaJmCTpr67BFDo2h9+0cQqdRoUSzxiMew/AxFOTd4cn+pxXqDXBUZGMHcy0O8OrGVP 8WZ0++FsOm5VK27Eh5pvxIkeRqpXt1nJJmiJnHeY+aukYUimEV5rCiUmfDpZR6dLGF6hC8vQlz1 4LsmgjOEbXf3el0DBmzmx3cdd/8iXQZD1c4+ZFOg/2ytUf7im27jbVfhAryYAcXjGPJgAKDcfqm bcM2N1VKEi16XowmBXZ0cyOwEqVNsvh/Nj1msiLOCcnh5vccemuvLTC5K+0UxUUaSeI1jpLCvZl 5HoXgDx2OceGALU60pUBJ4cN4RRPqVvPs9E5vrgPf55Jd910DtcJiXunGAaZ9CFryAV4KOqvVfn 0cT1ufjuv9ZomJmAANGGAwHPYJdJMheUnf98iWvuy/uWQEvE3zyAGWLWRlDBX6dLQ2lFgF7/ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-29_03,2025-07-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 clxscore=1015 adultscore=0 priorityscore=1501 mlxscore=0 spamscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507290104 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rob.clark@oss.qualcomm.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jul 28, 2025 at 3:15=E2=80=AFPM Rob Clark wrote: > > On Mon, Jul 28, 2025 at 2:04=E2=80=AFPM Connor Abbott wrote: > > > > On Mon, Jul 28, 2025 at 4:43=E2=80=AFPM Rob Clark wrote: > > > > > > This is needed to properly interpret some of the sections. > > > > > > Signed-off-by: Rob Clark > > > --- > > > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gp= u/drm/msm/adreno/a6xx_gpu_state.c > > > index faca2a0243ab..e586577e90de 100644 > > > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c > > > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c > > > @@ -1796,6 +1796,7 @@ static void a7xx_show_shader(struct a6xx_gpu_st= ate_obj *obj, > > > > > > print_name(p, " - type: ", a7xx_statetype_names[block->state= type]); > > > print_name(p, " - pipe: ", a7xx_pipe_names[block->pipeid])= ; > > > + drm_printf(p, " - location: %d", block->location); > > > > We should probably at least try to keep it proper YAML by indenting > > everything after another level... > > this made me realize I missed a \n... but otherwise I think the indent > is correct? Or should location not have a leading '-'? beyond that, even without the added location field, some random online yaml checker is telling me that we were already not proper yaml.. so I guess, :shrug:? BR, -R