From: "Rafał Miłecki" <zajec5@gmail.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [RFC][PATCH 1/2] drm/radeon: remove unneeded HDMI r/w ops on DCE4+
Date: Mon, 7 Oct 2013 18:47:10 +0200 [thread overview]
Message-ID: <CACna6ryXak-k0mfzNwb1h8eqOoNMxu8Kjx3y1ckfZ7ZJD2phzg@mail.gmail.com> (raw)
In-Reply-To: <CADnq5_Mi83n5_QpVWBTEFPoQYJ7CtsQpuvhbsLc_pu_xHKR8bA@mail.gmail.com>
2013/10/7 Alex Deucher <alexdeucher@gmail.com>:
> On Sun, Oct 6, 2013 at 4:46 PM, Rafał Miłecki <zajec5@gmail.com> wrote:
>> Write to HDMI_VBI_PACKET_CONTROL was duplicated.
>> Writes to AFMT_AUDIO_CRC_CONTROL and AFMT_RAMP_CONTROL[0-3] came from
>> DCE2/3 code (copy & paste) and were never needed on DCE4+.
>>
>> See https://bugzilla.kernel.org/show_bug.cgi?id=62591 for details.
>
> I think in general it would be better to do a read/modify/write
> sequences for all hdmi register updates rather than just writing.
> That's generally what the hw team recommends and what the catalyst
> driver does.
See my patch 3/2 for that :) I agree with you.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2013-10-07 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 20:46 [RFC][PATCH 1/2] drm/radeon: remove unneeded HDMI r/w ops on DCE4+ Rafał Miłecki
2013-10-06 20:46 ` [RFC][PATCH 2/2] drm/radeon: add missing writes for DCE4+ HDMI mode Rafał Miłecki
2013-10-07 16:35 ` [RFC][PATCH 1/2] drm/radeon: remove unneeded HDMI r/w ops on DCE4+ Alex Deucher
2013-10-07 16:47 ` Rafał Miłecki [this message]
2013-10-07 17:04 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACna6ryXak-k0mfzNwb1h8eqOoNMxu8Kjx3y1ckfZ7ZJD2phzg@mail.gmail.com \
--to=zajec5@gmail.com \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).