From: Emil Velikov <emil.l.velikov@gmail.com>
To: "Marcin Ślusarz" <marcin.slusarz@gmail.com>
Cc: ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [libdrm PATCH 2/2] configure.ac: don't detect disabled options dependencies
Date: Tue, 19 Jan 2016 10:26:16 +0200 [thread overview]
Message-ID: <CACvgo50MtYe5H66maQt=b1JwWiNPEvORjodyWW22pZqknS5caA@mail.gmail.com> (raw)
In-Reply-To: <20160109150529.GB5501@marcin-Inspiron-7720>
Hi Marcin,
On 9 January 2016 at 17:05, Marcin Ślusarz <marcin.slusarz@gmail.com> wrote:
> Currently with --disable-amdgpu --disable-valgrind --disable-cairo-tests
> cunit, valgrind and cairo are still detected.
>
Doesn't this patch make 1/2 obsolete ?
> Signed-off-by: Marcin Ślusarz <marcin.slusarz@gmail.com>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
> ---
> configure.ac | 36 ++++++++++++++++++++++--------------
> 1 file changed, 22 insertions(+), 14 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index c8c4ace..cc44e3f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -400,7 +404,9 @@ AC_ARG_ENABLE([cairo-tests],
> [AS_HELP_STRING([--enable-cairo-tests],
> [Enable support for Cairo rendering in tests (default: auto)])],
> [CAIRO=$enableval], [CAIRO=auto])
> -PKG_CHECK_MODULES(CAIRO, cairo, [HAVE_CAIRO=yes], [HAVE_CAIRO=no])
> +if test "x$CAIRO" != xno; then
> + PKG_CHECK_MODULES(CAIRO, cairo, [HAVE_CAIRO=yes], [HAVE_CAIRO=no])
> +fi
Namely: if we have disable-cairo-tests, the module will never be
checked, thus CAIRO_{CFLAGS,LIBS} will be empty. Obviously the user
can explicitly sets the CAIRO_* variables, in which case they're
cutting the branch they're standing on.
Please let me know if you'd prefer to have 1/2 regardless (or if I
missed something)
Thank you for sorting these.
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-01-19 8:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 15:05 [libdrm PATCH 2/2] configure.ac: don't detect disabled options dependencies Marcin Ślusarz
2016-01-19 8:26 ` Emil Velikov [this message]
2016-01-19 21:51 ` Marcin Ślusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACvgo50MtYe5H66maQt=b1JwWiNPEvORjodyWW22pZqknS5caA@mail.gmail.com' \
--to=emil.l.velikov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).