dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Jerry Han <jerry.han.hq@gmail.com>,
	Jitao Shi <jitao.shi@mediatek.com>,
	Derek Basehore <dbasehore@chromium.org>,
	ML dri-devel <dri-devel@lists.freedesktop.org>,
	Jerry Han <hanxu5@huaqin.corp-partner.google.com>,
	Rock wang <rock_wang@himax.com.cn>
Subject: Re: [PATCH 10/10] [v10] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel
Date: Mon, 5 Aug 2019 11:16:29 +0100	[thread overview]
Message-ID: <CACvgo50fVLODj0k8twd7tfVnOFv1s_veKxD+=ZGbD9cmNuLFSQ@mail.gmail.com> (raw)
In-Reply-To: <20190803143706.GA23157@ravnborg.org>

On Sat, 3 Aug 2019 at 15:37, Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Jerry.
>
> On Sat, Aug 03, 2019 at 10:40:44AM +0800, Jerry Han wrote:
> > V1: https://patchwork.freedesktop.org/patch/287425/
> > V2: https://patchwork.freedesktop.org/patch/289843/
> > V3: https://patchwork.freedesktop.org/patch/290393/
> > V4: https://patchwork.freedesktop.org/patch/290396/
> > V5: https://patchwork.freedesktop.org/patch/291131/   (only modify
> > commit message Added changelog, no files modified)
> > V6: https://patchwork.freedesktop.org/patch/291650/
> > V7: https://patchwork.freedesktop.org/patch/294141/
> > V8: https://patchwork.freedesktop.org/patch/301925/
> > V9: https://patchwork.freedesktop.org/patch/320514/
>
> > From 63bcc4f1e72713eca14c4b08e62bc3c07e67904a Mon Sep 17 00:00:00 2001
> > From: Jerry Han <hanxu5@huaqin.corp-partner.google.com>
> > Date: Thu, 1 Aug 2019 15:52:35 +0800
> > Subject: [PATCH 02/10] [v2,2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD
> >  panel
> >
> > Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI
> > panel.
> >
> > V2:
> > - Use SPDX identifier (Sam)
> > - Use necessary header files replace drmP.h (Sam)
> > - Delete unnecessary header files #include <linux/err.h> (Sam)
> > - Specifies a GPIOs array to control the reset timing,
> >     instead of reading "dsi-reset-sequence" data from DTS (Sam)
> > - Delete backlight_disable() function when already disabled (Sam)
> > - Use devm_of_find_backlight() replace of_find_backlight_by_node()
> >     (Sam)
> > - Move the necessary data in the DTS to the current file,
> >     like porch, display_mode and Init code etc. (Sam)
> > - Add compatible device "boe,himax8279d10p" (Sam)
> >
> > V1:
> > - Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI
> >     panel.
>
> Something went wrong when you tried to submit v10.
> Please try again.
>
Apart from that, seems like the init sequence has changed drastically.

What is the reason behind this? Was there a bug with previous patches?

For reference in v8 the sequence was nearly identical for 8 and 10
inch devices - 8-10 line difference.
Now we're looking at ~250 ...

-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-08-05 10:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-03  2:40 [PATCH 10/10] [v10] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel Jerry Han
2019-08-03 14:37 ` Sam Ravnborg
2019-08-05 10:16   ` Emil Velikov [this message]
2019-08-12  3:22     ` Jerry Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACvgo50fVLODj0k8twd7tfVnOFv1s_veKxD+=ZGbD9cmNuLFSQ@mail.gmail.com' \
    --to=emil.l.velikov@gmail.com \
    --cc=dbasehore@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hanxu5@huaqin.corp-partner.google.com \
    --cc=jerry.han.hq@gmail.com \
    --cc=jitao.shi@mediatek.com \
    --cc=rock_wang@himax.com.cn \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).