Re: [PATCH 6/7] tests/amdgpu: make amdgpu_command_submission_sdma_copy_linear generic

[Emil Velikov <emil.l.velikov@gmail.com>]

On 4 February 2016 at 15:51, Alex Deucher <alexdeucher@gmail.com> wrote:
> On Thu, Feb 4, 2016 at 10:47 AM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>> On 4 February 2016 at 14:59, Alex Deucher <alexdeucher@gmail.com> wrote:
>>> So it can be shared for CP tests.
>>>
>>> Reviewed-by: Ken Wang <Qingqing.Wang@amd.com>
>>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>>> ---
>>>  tests/amdgpu/basic_tests.c | 27 +++++++++++++++++----------
>>>  1 file changed, 17 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/tests/amdgpu/basic_tests.c b/tests/amdgpu/basic_tests.c
>>> index 7806be7..701ccf1 100644
>>> --- a/tests/amdgpu/basic_tests.c
>>> +++ b/tests/amdgpu/basic_tests.c
>>> @@ -57,6 +57,7 @@ static void amdgpu_test_exec_cs_helper(amdgpu_context_handle context_handle,
>>>                                        struct amdgpu_cs_request *ibs_request);
>>>  static void amdgpu_command_submission_write_linear_helper(unsigned ip_type);
>>>  static void amdgpu_command_submission_const_fill_helper(unsigned ip_type);
>>> +static void amdgpu_command_submission_copy_linear_helper(unsigned ip_type);
>>>
>> Unless I'm missing something we don't need these three ?
>
> They are used by patches 3, 5, and 7.
>
You're absolutely correct. I forgot that the amdgpu tests keep the
brief functions at the top (one-online wrappers, test list). Sorry
about the noise.

Glad to see that there are tests sent out as the kernel bits get
implemented. Keep it up :-)

-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel