Re: [PATCH 0/8] Cleanup CRTC .enable()/.disable() cargo-cult

From: Emil Velikov <emil.l.velikov@gmail.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	Liviu Dudau <liviu.dudau@arm.com>,
	ML dri-devel <dri-devel@lists.freedesktop.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	Thomas Hellstrom <thellstrom@vmware.com>,
	Alexey Brodkin <abrodkin@synopsys.com>,
	Xinliang Liu <z.liuxinliang@hisilicon.com>,
	Xinwei Kong <kong.kongxinwei@hisilicon.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	VMware Graphics <linux-graphics-maintainer@vmware.com>,
	Mali DP Maintainers <malidp@foss.arm.com>,
	Chen Feng <puck.chen@hisilicon.com>, Jyri Sarha <jsarha@ti.com>,
	Dave Airlie <airlied@redhat.com>,
	Vincent Abriou <vincent.abriou@st.com>,
	Alison Wang <alison.wang@freescale.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Philippe Cornu <philippe.cornu@st.com>,
	Yannick
Subject: Re: [PATCH 0/8] Cleanup CRTC .enable()/.disable() cargo-cult
Date: Wed, 28 Jun 2017 12:27:06 +0100	[thread overview]
Message-ID: <CACvgo5332oa0LMzVyPAo_LSbPss8stF2ck7EhMvgahsi9yvM6g@mail.gmail.com> (raw)
In-Reply-To: <20170627203843.27004-1-laurent.pinchart+renesas@ideasonboard.com>

Hi Laurent,

On 27 June 2017 at 21:38, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> Hello,
>
> The atomic helpers favour the .enable() and .atomic_disable() CRTC helper
> operations, but still support the legacy .prepare(), .commit(), .disable() and
> .dpms() operations. Some drivers have been updated, but most still use various
> combination of new and legacy operations, leading to confusion among new
> developers when they read the code.
>
Just had a crazy idea:

Would it make sense for the function(s) that takes the
driver_foo_funcs as an argument to cross-check for such mistakes?
Since many of the hooks are optional, one could check for the
'forbidden' combinations:
Atomic drivers should not have any legacy hooks set, while legacy ones
should not have any of the atomic ones.

Of course the idea is not restricted to the CRTC helpers -
drm_{crtc,encoder,connector,plane,mode_config}_{helper_,}funcs should
all be applicable.

Regards,
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel