* [patch -next] drm/radeon/dpm/btc: off by one in btc_set_mc_special_registers()
@ 2013-07-01 16:35 Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-07-01 16:35 UTC (permalink / raw)
To: David Airlie; +Cc: Alex Deucher, Jerome Glisse, dri-devel, kernel-janitors
It should be ">=" instead of ">" here. The table->mc_reg_address[]
array has SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE (16) elements.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/radeon/btc_dpm.c b/drivers/gpu/drm/radeon/btc_dpm.c
index bab0185..55491e7 100644
--- a/drivers/gpu/drm/radeon/btc_dpm.c
+++ b/drivers/gpu/drm/radeon/btc_dpm.c
@@ -1913,7 +1913,7 @@ static int btc_set_mc_special_registers(struct radeon_device *rdev,
}
j++;
- if (j > SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
+ if (j >= SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
return -EINVAL;
tmp = RREG32(MC_PMG_CMD_MRS);
@@ -1928,7 +1928,7 @@ static int btc_set_mc_special_registers(struct radeon_device *rdev,
}
j++;
- if (j > SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
+ if (j >= SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
return -EINVAL;
break;
case MC_SEQ_RESERVE_M >> 2:
@@ -1942,7 +1942,7 @@ static int btc_set_mc_special_registers(struct radeon_device *rdev,
}
j++;
- if (j > SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
+ if (j >= SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
return -EINVAL;
break;
default:
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [patch -next] drm/radeon/dpm/btc: off by one in btc_set_mc_special_registers()
@ 2013-09-27 20:18 Dan Carpenter
2013-10-02 15:33 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2013-09-27 20:18 UTC (permalink / raw)
To: David Airlie; +Cc: Alex Deucher, Jerome Glisse, dri-devel, kernel-janitors
It should be ">=" instead of ">" here. The table->mc_reg_address[]
array has SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE (16) elements.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Resend.
diff --git a/drivers/gpu/drm/radeon/btc_dpm.c b/drivers/gpu/drm/radeon/btc_dpm.c
index bab0185..55491e7 100644
--- a/drivers/gpu/drm/radeon/btc_dpm.c
+++ b/drivers/gpu/drm/radeon/btc_dpm.c
@@ -1913,7 +1913,7 @@ static int btc_set_mc_special_registers(struct radeon_device *rdev,
}
j++;
- if (j > SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
+ if (j >= SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
return -EINVAL;
tmp = RREG32(MC_PMG_CMD_MRS);
@@ -1928,7 +1928,7 @@ static int btc_set_mc_special_registers(struct radeon_device *rdev,
}
j++;
- if (j > SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
+ if (j >= SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
return -EINVAL;
break;
case MC_SEQ_RESERVE_M >> 2:
@@ -1942,7 +1942,7 @@ static int btc_set_mc_special_registers(struct radeon_device *rdev,
}
j++;
- if (j > SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
+ if (j >= SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
return -EINVAL;
break;
default:
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch -next] drm/radeon/dpm/btc: off by one in btc_set_mc_special_registers()
2013-09-27 20:18 [patch -next] drm/radeon/dpm/btc: off by one in btc_set_mc_special_registers() Dan Carpenter
@ 2013-10-02 15:33 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2013-10-02 15:33 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, Alex Deucher, Jerome Glisse, kernel-janitors,
Maling list - DRI developers
On Fri, Sep 27, 2013 at 4:18 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> It should be ">=" instead of ">" here. The table->mc_reg_address[]
> array has SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE (16) elements.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Resend.
Applied. thanks!
Alex
>
> diff --git a/drivers/gpu/drm/radeon/btc_dpm.c b/drivers/gpu/drm/radeon/btc_dpm.c
> index bab0185..55491e7 100644
> --- a/drivers/gpu/drm/radeon/btc_dpm.c
> +++ b/drivers/gpu/drm/radeon/btc_dpm.c
> @@ -1913,7 +1913,7 @@ static int btc_set_mc_special_registers(struct radeon_device *rdev,
> }
> j++;
>
> - if (j > SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
> + if (j >= SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
> return -EINVAL;
>
> tmp = RREG32(MC_PMG_CMD_MRS);
> @@ -1928,7 +1928,7 @@ static int btc_set_mc_special_registers(struct radeon_device *rdev,
> }
> j++;
>
> - if (j > SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
> + if (j >= SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
> return -EINVAL;
> break;
> case MC_SEQ_RESERVE_M >> 2:
> @@ -1942,7 +1942,7 @@ static int btc_set_mc_special_registers(struct radeon_device *rdev,
> }
> j++;
>
> - if (j > SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
> + if (j >= SMC_EVERGREEN_MC_REGISTER_ARRAY_SIZE)
> return -EINVAL;
> break;
> default:
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-02 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-27 20:18 [patch -next] drm/radeon/dpm/btc: off by one in btc_set_mc_special_registers() Dan Carpenter
2013-10-02 15:33 ` Alex Deucher
-- strict thread matches above, loose matches on Subject: below --
2013-07-01 16:35 Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).